From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudip Mukherjee Subject: Re: [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c Date: Thu, 17 Dec 2015 22:18:39 +0530 Message-ID: <20151217164839.GA13575@sudip-pc> References: <1450364746-815-1-git-send-email-paul.gortmaker@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1450364746-815-1-git-send-email-paul.gortmaker@windriver.com> Sender: linux-kernel-owner@vger.kernel.org To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Nicolas Ferre , Jiri Slaby , linux-serial@vger.kernel.org, Greg Kroah-Hartman , Sudip Mukherjee List-Id: linux-serial@vger.kernel.org On Thu, Dec 17, 2015 at 10:05:46AM -0500, Paul Gortmaker wrote: > In commit c39dfebc7798956fd2140ae6321786ff35da30c3 ("drivers/tty/serial: > make serial/atmel_serial.c explicitly non-modular") we removed the code > relating to modular support since it currently only supports built in. > > However, when redoing my build coverage for mips allmodconfig, which > sets CONFIG_OF, I noticed a remaining line that needs to be removed, > else we will get a build failure for an undefined module macro. > > Unfortunately this didn't appear for any of the other arch I tested > more frequently, such as ARM. > > Since MODULE_DEVICE_TABLE is a no-op for non-modular code, we can just > remove the offending line. > > Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular") > Cc: Nicolas Ferre > Cc: Jiri Slaby > Cc: linux-serial@vger.kernel.org > Cc: Greg Kroah-Hartman > Cc: Sudip Mukherjee > Reported-by: Sudip Mukherjee Acked-by: Sudip Mukherjee regards sudip