* [PATCH] serial: atmel: remove module device table
@ 2015-12-18 14:49 Arnd Bergmann
2015-12-20 1:39 ` Paul Gortmaker
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2015-12-18 14:49 UTC (permalink / raw)
To: linux-serial, gregkh
Cc: Paul Gortmaker, Jiri Slaby, Nicolas Ferre, alexandre.belloni,
linux-kernel, linux-arm-kernel
A recent patch removed most of the module-specific code from the atmel
serial driver, but left the MODULE_DEVICE_TABLE in place, so we can't
build it any more:
drivers/tty/serial/atmel_serial.c:192:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
drivers/tty/serial/atmel_serial.c:192:1: warning: parameter names (without types) in function declaration
This removes the table as well to avoid the error.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index 50e785a0ea73..1c0884d8ef32 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -188,8 +188,6 @@ static const struct of_device_id atmel_serial_dt_ids[] = {
{ .compatible = "atmel,at91sam9260-usart" },
{ /* sentinel */ }
};
-
-MODULE_DEVICE_TABLE(of, atmel_serial_dt_ids);
#endif
static inline struct atmel_uart_port *
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] serial: atmel: remove module device table
2015-12-18 14:49 [PATCH] serial: atmel: remove module device table Arnd Bergmann
@ 2015-12-20 1:39 ` Paul Gortmaker
0 siblings, 0 replies; 2+ messages in thread
From: Paul Gortmaker @ 2015-12-20 1:39 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-serial, gregkh, Jiri Slaby, Nicolas Ferre,
alexandre.belloni, linux-kernel, linux-arm-kernel
[[PATCH] serial: atmel: remove module device table] On 18/12/2015 (Fri 15:49) Arnd Bergmann wrote:
> A recent patch removed most of the module-specific code from the atmel
> serial driver, but left the MODULE_DEVICE_TABLE in place, so we can't
> build it any more:
>
> drivers/tty/serial/atmel_serial.c:192:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
> drivers/tty/serial/atmel_serial.c:192:1: warning: parameter names (without types) in function declaration
>
> This removes the table as well to avoid the error.
I sent the same fix on Thursday. Again, sorry that my testing did
not uncover this earlier. I was build testing for ARM on almost a daily
basis but not so regularly for MIPS.
http://lkml.kernel.org/r/1450364746-815-1-git-send-email-paul.gortmaker@windriver.com
Paul.
--
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
>
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index 50e785a0ea73..1c0884d8ef32 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -188,8 +188,6 @@ static const struct of_device_id atmel_serial_dt_ids[] = {
> { .compatible = "atmel,at91sam9260-usart" },
> { /* sentinel */ }
> };
> -
> -MODULE_DEVICE_TABLE(of, atmel_serial_dt_ids);
> #endif
>
> static inline struct atmel_uart_port *
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-20 1:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-18 14:49 [PATCH] serial: atmel: remove module device table Arnd Bergmann
2015-12-20 1:39 ` Paul Gortmaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).