Linux Serial subsystem development
 help / color / mirror / Atom feed
From: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v3] serial: 8250: add gpio support to exar
Date: Sun, 20 Dec 2015 16:43:53 +0000	[thread overview]
Message-ID: <20151220164353.6ef29f77@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1450617891-26167-1-git-send-email-sudipm.mukherjee@gmail.com>

> v3: Alan commented on v2, few things like NULL check, name of the gpio chip,
> moving some more code into the gpio code. He also commented on it being
> a separate module, but since this will not be needed by someone who is not
> using Exar chip, and even those who are using, some of them may not need it.
> This is optional for only those who wants to use the gpio capability of that
> chip. So kept it as a separate module. Waiting for your comments on that.

That doesn't work because you reference the methods in it so it will
always be dragged in. You would have to make the exar driver an MFD that
provided a serial and a gpio binding to fix that up I think, or instead
of having the serial driver call into your gpio driver (thus forcing the
module into memory) you would have the serial driver create a platform
device or similar that the GPIO device bound to.

Alan

  parent reply	other threads:[~2015-12-20 16:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-20 13:24 [PATCH v3] serial: 8250: add gpio support to exar Sudip Mukherjee
2015-12-20 14:18 ` Andy Shevchenko
2015-12-20 14:47   ` Sudip Mukherjee
2015-12-20 15:05     ` Andy Shevchenko
2015-12-20 16:41     ` One Thousand Gnomes
2015-12-20 17:11       ` Sudip Mukherjee
2015-12-20 17:28         ` One Thousand Gnomes
2015-12-20 16:43 ` One Thousand Gnomes [this message]
2015-12-20 17:28   ` Sudip Mukherjee
2015-12-20 17:42     ` One Thousand Gnomes
2015-12-21 15:19       ` Sudip Mukherjee
2015-12-21 18:28         ` Andy Shevchenko
2015-12-22  4:27           ` Sudip Mukherjee
2015-12-22  9:58             ` Andy Shevchenko
2015-12-22 10:08               ` Sudip Mukherjee
2015-12-22 10:15                 ` Andy Shevchenko
2015-12-22 10:37                   ` Sudip Mukherjee
2015-12-20 17:46     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151220164353.6ef29f77@lxorguk.ukuu.org.uk \
    --to=gnomes@lxorguk.ukuu.org.uk \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox