From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Timur Tabi <timur@codeaurora.org>
Cc: Peter Hurley <peter@hurleysoftware.com>,
Andre Przywara <andre.przywara@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Andrew Jackson <Andrew.Jackson@arm.com>,
linux-serial@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Huang Shijie <shijie.huang@arm.com>, Jiri Slaby <jslaby@suse.com>,
Jun Nie <jun.nie@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 05/12] tty: amba-pl011: add register lookup table
Date: Thu, 24 Dec 2015 15:40:27 +0000 [thread overview]
Message-ID: <20151224154027.GH8644@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAOZdJXXdMHG7c9yDTo+oh7uNPCmH_Mc08s5YCoL3j--7uj5Mow@mail.gmail.com>
On Thu, Dec 24, 2015 at 09:35:52AM -0600, Timur Tabi wrote:
> On Thu, Dec 24, 2015 at 9:05 AM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > On Thu, Dec 24, 2015 at 09:03:12AM -0600, Timur Tabi wrote:
> >> On Thu, Dec 24, 2015 at 12:54 AM, Huang Shijie <shijie.huang@arm.com> wrote:
> >> > My kernel cmdline:
> >> > console=ttyAMA0,115200 earlycon=pl011,0x7ff80000 root=/dev/sda1 rootwait verbose debug sky2.mac_address=0x00,0x02,0xF7,0x00,0x63,0x3C dtb=r1a57.dtb
> >>
> >> earlycon is broken with Russell's patches. My patch fixes it, but
> >> only for standard pl011 devices.
> >
> > No, it shouldn't be. Earlycon uses pl011_putc() which remains exactly
> > the same as it was before these patches.
>
> while (readl(port->membase + REG_FR) & UART01x_FR_TXFF)
>
> is broken because REG_FR is equal to 1.
Patch 4, which changes to the REG_* stuff, does not (explicitly) touch
this because it _will_ break stuff.
--
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-12-24 15:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 17:39 [PATCH 00/12] Prepare amba-pl011 for ZTE UART support Russell King - ARM Linux
2015-11-16 17:40 ` [PATCH 01/12] tty: amba-pl011: add register accessor functions Russell King
2015-12-05 18:57 ` Peter Hurley
2015-12-24 15:14 ` Russell King - ARM Linux
2015-11-16 17:40 ` [PATCH 02/12] tty: amba-pl011: convert accessor functions to take uart_amba_port Russell King
2015-11-16 17:40 ` [PATCH 03/12] tty: amba-pl011: add helper to detect split LCRH register Russell King
2015-11-16 17:40 ` [PATCH 04/12] tty: amba-pl011: prepare REG_* register indexes Russell King
2015-11-16 17:40 ` [PATCH 05/12] tty: amba-pl011: add register lookup table Russell King
2015-11-19 14:10 ` Dave Martin
2015-12-24 6:54 ` Huang Shijie
2015-12-24 11:01 ` Russell King - ARM Linux
2015-12-24 15:03 ` Timur Tabi
2015-12-24 15:05 ` Russell King - ARM Linux
2015-12-24 15:35 ` Timur Tabi
2015-12-24 15:40 ` Russell King - ARM Linux [this message]
2015-12-24 15:50 ` Timur Tabi
2015-12-24 15:54 ` Russell King - ARM Linux
2015-12-24 16:07 ` Russell King - ARM Linux
2015-12-24 16:51 ` Russell King - ARM Linux
2015-11-16 17:40 ` [PATCH 06/12] tty: amba-pl011: add register offset table to vendor data Russell King
2015-11-16 17:40 ` [PATCH 07/12] tty: amba-pl011: add ST register offset table Russell King
2015-11-16 17:40 ` [PATCH 08/12] tty: amba-pl011: clean up LCR register offsets Russell King
2015-11-16 17:40 ` [PATCH 09/12] tty: amba-pl011: remove ST micro registers from standard table Russell King
2015-11-16 17:40 ` [PATCH 10/12] tty: amba-pl011: add support for 32-bit register access Russell King
2015-11-16 17:45 ` Timur Tabi
2015-11-16 17:52 ` Russell King - ARM Linux
2015-11-16 18:25 ` Timur Tabi
2015-11-16 18:30 ` Russell King - ARM Linux
2015-11-16 20:52 ` Timur Tabi
2015-11-16 21:18 ` Peter Hurley
2015-11-16 17:40 ` [PATCH 11/12] tty: amba-pl011: add support for ZTE UART (EXPERIMENTAL) Russell King
2015-11-16 17:41 ` [PATCH 12/12] tty: amba-pl011: switch to using relaxed IO accessors Russell King
2015-12-05 18:49 ` [PATCH 00/12] Prepare amba-pl011 for ZTE UART support Peter Hurley
2015-12-05 19:06 ` Timur Tabi
2015-12-13 6:36 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151224154027.GH8644@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=Andrew.Jackson@arm.com \
--cc=andre.przywara@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=jun.nie@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=shijie.huang@arm.com \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).