[PATCH -next] tty/serial: atmel: Include module.h to fix build failure

[PATCH -next] tty/serial: atmel: Include module.h to fix build failure

[Guenter Roeck]

If serial/atmel_serial.c is compiled with devicetree enabled, the
following build error is observed.

drivers/tty/serial/atmel_serial.c:192:1: warning:
	data definition has no type or storage class
drivers/tty/serial/atmel_serial.c:192:1: error:
	type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
drivers/tty/serial/atmel_serial.c:192:1: warning:
	parameter names (without types) in function declaration

MODULE_DEVICE_TABLE is used to specify devicetree compatibilities.

Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/tty/serial/atmel_serial.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index 50e785a0ea73..71c385b09db8 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -22,6 +22,7 @@
  * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  *
  */
+#include <linux/module.h>
 #include <linux/tty.h>
 #include <linux/ioport.h>
 #include <linux/slab.h>
-- 
2.1.4

Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure

[Greg Kroah-Hartman]

On Sat, Jan 09, 2016 at 10:15:35AM -0800, Guenter Roeck wrote:
> If serial/atmel_serial.c is compiled with devicetree enabled, the
> following build error is observed.
> 
> drivers/tty/serial/atmel_serial.c:192:1: warning:
> 	data definition has no type or storage class
> drivers/tty/serial/atmel_serial.c:192:1: error:
> 	type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
> drivers/tty/serial/atmel_serial.c:192:1: warning:
> 	parameter names (without types) in function declaration
> 
> MODULE_DEVICE_TABLE is used to specify devicetree compatibilities.
> 
> Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  drivers/tty/serial/atmel_serial.c | 1 +
>  1 file changed, 1 insertion(+)

This hit my tree last night already with commit
041497eb721ddbdc1e690316976dd8ba7bc136a2, so all should be fine in the
next linux-next release.

thanks,

greg k-h

Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure

[Sudip Mukherjee]

On Sat, Jan 09, 2016 at 10:29:08AM -0800, Greg Kroah-Hartman wrote:
> On Sat, Jan 09, 2016 at 10:15:35AM -0800, Guenter Roeck wrote:
> > If serial/atmel_serial.c is compiled with devicetree enabled, the
> > following build error is observed.
> > 
> > drivers/tty/serial/atmel_serial.c:192:1: warning:
> > 	data definition has no type or storage class
> > drivers/tty/serial/atmel_serial.c:192:1: error:
> > 	type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
> > drivers/tty/serial/atmel_serial.c:192:1: warning:
> > 	parameter names (without types) in function declaration
> > 
> > MODULE_DEVICE_TABLE is used to specify devicetree compatibilities.
> > 
> > Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
> > Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> >  drivers/tty/serial/atmel_serial.c | 1 +
> >  1 file changed, 1 insertion(+)
> 
> This hit my tree last night already with commit
> 041497eb721ddbdc1e690316976dd8ba7bc136a2, so all should be fine in the
> next linux-next release.

Hi Guenter,
Just a thought. It has happended many times that we both have sent
patches to fix the same build fail. Maybe your patch got applied and
mine came late or maybe mine was applied and you came late. But I think
if we have a separate mailing list where people interested to fix and
monitor build failures will be members and we Cc that list whenever we
send patch for build fail and then in that case we will know that
someone else has already sent a patch for this failure and we can invest
the time in some other problem.

regards
sudip

Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure

[Guenter Roeck]

On Mon, Jan 11, 2016 at 02:05:36PM +0530, Sudip Mukherjee wrote:
> On Sat, Jan 09, 2016 at 10:29:08AM -0800, Greg Kroah-Hartman wrote:
> > On Sat, Jan 09, 2016 at 10:15:35AM -0800, Guenter Roeck wrote:
> > > If serial/atmel_serial.c is compiled with devicetree enabled, the
> > > following build error is observed.
> > > 
> > > drivers/tty/serial/atmel_serial.c:192:1: warning:
> > > 	data definition has no type or storage class
> > > drivers/tty/serial/atmel_serial.c:192:1: error:
> > > 	type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
> > > drivers/tty/serial/atmel_serial.c:192:1: warning:
> > > 	parameter names (without types) in function declaration
> > > 
> > > MODULE_DEVICE_TABLE is used to specify devicetree compatibilities.
> > > 
> > > Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
> > > Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> > > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > > ---
> > >  drivers/tty/serial/atmel_serial.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > 
> > This hit my tree last night already with commit
> > 041497eb721ddbdc1e690316976dd8ba7bc136a2, so all should be fine in the
> > next linux-next release.
> 
> Hi Guenter,
> Just a thought. It has happended many times that we both have sent
> patches to fix the same build fail. Maybe your patch got applied and
> mine came late or maybe mine was applied and you came late. But I think
> if we have a separate mailing list where people interested to fix and
> monitor build failures will be members and we Cc that list whenever we
> send patch for build fail and then in that case we will know that
> someone else has already sent a patch for this failure and we can invest
> the time in some other problem.
> 

Hi Sudip,

I agree, it would make sense to have a build(/runtime?)-fixes-only mailing
list. Question though is how to limit noise on such a list and, of course,
where and how to set it up. Any thoughts ?

Guenter

Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure

[Sudip Mukherjee]

On Mon, Jan 11, 2016 at 03:11:01AM -0800, Guenter Roeck wrote:
> On Mon, Jan 11, 2016 at 02:05:36PM +0530, Sudip Mukherjee wrote:
> > On Sat, Jan 09, 2016 at 10:29:08AM -0800, Greg Kroah-Hartman wrote:
> > > On Sat, Jan 09, 2016 at 10:15:35AM -0800, Guenter Roeck wrote:
> > > > If serial/atmel_serial.c is compiled with devicetree enabled, the
> > > > following build error is observed.
> > > > 
> > > > drivers/tty/serial/atmel_serial.c:192:1: warning:
> > > > 	data definition has no type or storage class
> > > > drivers/tty/serial/atmel_serial.c:192:1: error:
> > > > 	type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
> > > > drivers/tty/serial/atmel_serial.c:192:1: warning:
> > > > 	parameter names (without types) in function declaration
> > > > 
> > > > MODULE_DEVICE_TABLE is used to specify devicetree compatibilities.
> > > > 
> > > > Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
> > > > Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> > > > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > > > ---
> > > >  drivers/tty/serial/atmel_serial.c | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > 
> > > This hit my tree last night already with commit
> > > 041497eb721ddbdc1e690316976dd8ba7bc136a2, so all should be fine in the
> > > next linux-next release.
> > 
> > Hi Guenter,
> > Just a thought. It has happended many times that we both have sent
> > patches to fix the same build fail. Maybe your patch got applied and
> > mine came late or maybe mine was applied and you came late. But I think
> > if we have a separate mailing list where people interested to fix and
> > monitor build failures will be members and we Cc that list whenever we
> > send patch for build fail and then in that case we will know that
> > someone else has already sent a patch for this failure and we can invest
> > the time in some other problem.
> > 
> 
> Hi Sudip,
> 
> I agree, it would make sense to have a build(/runtime?)-fixes-only mailing
> list. Question though is how to limit noise on such a list

The list can be moderated for non-subscribers. We both can be admin and
can approve the mails if it is relevant to this list. Due to our
timezones atleast one of us will be always available to approve mails.

> and, of course, > where and how to set it up. Any thoughts ?

since the list is kernel related, i think the best place should be
vger.kernel.org but I have no idea how or whom to approach to have a
list there. Maybe Greg can guide.
And if that is not possible then there are many alternatives.

regards
sudip

Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure

[Paul Gortmaker]

On 2016-01-11 06:11 AM, Guenter Roeck wrote:
> On Mon, Jan 11, 2016 at 02:05:36PM +0530, Sudip Mukherjee wrote:
>> On Sat, Jan 09, 2016 at 10:29:08AM -0800, Greg Kroah-Hartman wrote:
>>> On Sat, Jan 09, 2016 at 10:15:35AM -0800, Guenter Roeck wrote:
>>>> If serial/atmel_serial.c is compiled with devicetree enabled, the
>>>> following build error is observed.
>>>>
>>>> drivers/tty/serial/atmel_serial.c:192:1: warning:
>>>> 	data definition has no type or storage class
>>>> drivers/tty/serial/atmel_serial.c:192:1: error:
>>>> 	type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
>>>> drivers/tty/serial/atmel_serial.c:192:1: warning:
>>>> 	parameter names (without types) in function declaration
>>>>
>>>> MODULE_DEVICE_TABLE is used to specify devicetree compatibilities.
>>>>
>>>> Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
>>>> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
>>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>>> ---
>>>>  drivers/tty/serial/atmel_serial.c | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>
>>> This hit my tree last night already with commit
>>> 041497eb721ddbdc1e690316976dd8ba7bc136a2, so all should be fine in the
>>> next linux-next release.
>>
>> Hi Guenter,
>> Just a thought. It has happended many times that we both have sent
>> patches to fix the same build fail. Maybe your patch got applied and
>> mine came late or maybe mine was applied and you came late. But I think
>> if we have a separate mailing list where people interested to fix and
>> monitor build failures will be members and we Cc that list whenever we
>> send patch for build fail and then in that case we will know that
>> someone else has already sent a patch for this failure and we can invest
>> the time in some other problem.
>>
> 
> Hi Sudip,
> 
> I agree, it would make sense to have a build(/runtime?)-fixes-only mailing
> list. Question though is how to limit noise on such a list and, of course,
> where and how to set it up. Any thoughts ?

Since most (all?) of these kind of fails are on linux-next, why not
do what everyone else does, and report the fail there and/or ensure
the fix is cc'd there?   Before I waste time trying to fix sth on
linux-next, I always google for the error msg and many times that
leads me to a lkml or linux-next post where it was reported and
fixed already.

Paul.

Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure

[Guenter Roeck]

On 01/11/2016 07:08 AM, Paul Gortmaker wrote:
> On 2016-01-11 06:11 AM, Guenter Roeck wrote:
>> On Mon, Jan 11, 2016 at 02:05:36PM +0530, Sudip Mukherjee wrote:
>>> On Sat, Jan 09, 2016 at 10:29:08AM -0800, Greg Kroah-Hartman wrote:
>>>> On Sat, Jan 09, 2016 at 10:15:35AM -0800, Guenter Roeck wrote:
>>>>> If serial/atmel_serial.c is compiled with devicetree enabled, the
>>>>> following build error is observed.
>>>>>
>>>>> drivers/tty/serial/atmel_serial.c:192:1: warning:
>>>>> 	data definition has no type or storage class
>>>>> drivers/tty/serial/atmel_serial.c:192:1: error:
>>>>> 	type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
>>>>> drivers/tty/serial/atmel_serial.c:192:1: warning:
>>>>> 	parameter names (without types) in function declaration
>>>>>
>>>>> MODULE_DEVICE_TABLE is used to specify devicetree compatibilities.
>>>>>
>>>>> Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
>>>>> Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
>>>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>>>> ---
>>>>>   drivers/tty/serial/atmel_serial.c | 1 +
>>>>>   1 file changed, 1 insertion(+)
>>>>
>>>> This hit my tree last night already with commit
>>>> 041497eb721ddbdc1e690316976dd8ba7bc136a2, so all should be fine in the
>>>> next linux-next release.
>>>
>>> Hi Guenter,
>>> Just a thought. It has happended many times that we both have sent
>>> patches to fix the same build fail. Maybe your patch got applied and
>>> mine came late or maybe mine was applied and you came late. But I think
>>> if we have a separate mailing list where people interested to fix and
>>> monitor build failures will be members and we Cc that list whenever we
>>> send patch for build fail and then in that case we will know that
>>> someone else has already sent a patch for this failure and we can invest
>>> the time in some other problem.
>>>
>>
>> Hi Sudip,
>>
>> I agree, it would make sense to have a build(/runtime?)-fixes-only mailing
>> list. Question though is how to limit noise on such a list and, of course,
>> where and how to set it up. Any thoughts ?
>
> Since most (all?) of these kind of fails are on linux-next, why not

Most or many, but not all.

> do what everyone else does, and report the fail there and/or ensure
> the fix is cc'd there?   Before I waste time trying to fix sth on
> linux-next, I always google for the error msg and many times that
> leads me to a lkml or linux-next post where it was reported and
> fixed already.

Many times, Sudip and I end up fixing problems literally in parallel,
and it happened quite often lately that we do send patches in parallel.
Even if I do a Google search for an error message, it happens quite
often that I get no results, yet the fix is already out there on
some list.

Sudip, one option would be to set up a semi-private mailing list.
My build tests now have a dedicated virtual host (kerneltests.org).
I could set up a managed list there.

Guenter

Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure

[Joe Perches]

On Tue, 2016-01-12 at 21:35 -0800, Guenter Roeck wrote:
> On 01/11/2016 07:08 AM, Paul Gortmaker wrote:
> > On 2016-01-11 06:11 AM, Guenter Roeck wrote:
> > > On Mon, Jan 11, 2016 at 02:05:36PM +0530, Sudip Mukherjee wrote:
> > > > On Sat, Jan 09, 2016 at 10:29:08AM -0800, Greg Kroah-Hartman wrote:
> > > > > On Sat, Jan 09, 2016 at 10:15:35AM -0800, Guenter Roeck wrote:
> > > > > > If serial/atmel_serial.c is compiled with devicetree enabled, the
> > > > > > following build error is observed.
> > > > > > 
> > > > > > drivers/tty/serial/atmel_serial.c:192:1: warning:
> > > > > > 	data definition has no type or storage class
> > > > > > drivers/tty/serial/atmel_serial.c:192:1: error:
> > > > > > 	type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
> > > > > > drivers/tty/serial/atmel_serial.c:192:1: warning:
> > > > > > 	parameter names (without types) in function declaration
> > > > > > 
> > > > > > MODULE_DEVICE_TABLE is used to specify devicetree compatibilities.
> > > > > > 
> > > > > > Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
> > > > > > Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
> > > > > > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > > > > > ---
> > > > > >   drivers/tty/serial/atmel_serial.c | 1 +
> > > > > >   1 file changed, 1 insertion(+)
> > > > > 
> > > > > This hit my tree last night already with commit
> > > > > 041497eb721ddbdc1e690316976dd8ba7bc136a2, so all should be fine in the
> > > > > next linux-next release.
> > > > 
> > > > Hi Guenter,
> > > > Just a thought. It has happended many times that we both have sent
> > > > patches to fix the same build fail. Maybe your patch got applied and
> > > > mine came late or maybe mine was applied and you came late. But I think
> > > > if we have a separate mailing list where people interested to fix and
> > > > monitor build failures will be members and we Cc that list whenever we
> > > > send patch for build fail and then in that case we will know that
> > > > someone else has already sent a patch for this failure and we can invest
> > > > the time in some other problem.
> > > > 
> > > 
> > > Hi Sudip,
> > > 
> > > I agree, it would make sense to have a build(/runtime?)-fixes-only mailing
> > > list. Question though is how to limit noise on such a list and, of course,
> > > where and how to set it up. Any thoughts ?
> > 
> > Since most (all?) of these kind of fails are on linux-next, why not
> 
> Most or many, but not all.
> 
> > do what everyone else does, and report the fail there and/or ensure
> > the fix is cc'd there?   Before I waste time trying to fix sth on
> > linux-next, I always google for the error msg and many times that
> > leads me to a lkml or linux-next post where it was reported and
> > fixed already.
> 
> Many times, Sudip and I end up fixing problems literally in parallel,
> and it happened quite often lately that we do send patches in parallel.
> Even if I do a Google search for an error message, it happens quite
> often that I get no results, yet the fix is already out there on
> some list.
> 
> Sudip, one option would be to set up a semi-private mailing list.
> My build tests now have a dedicated virtual host (kerneltests.org).
> I could set up a managed list there.

Perhaps it'd be better to have something like linux-build-failures@vger.kernel.org

Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure

[Sudip Mukherjee]

On Tue, Jan 12, 2016 at 09:44:10PM -0800, Joe Perches wrote:
> On Tue, 2016-01-12 at 21:35 -0800, Guenter Roeck wrote:
> > On 01/11/2016 07:08 AM, Paul Gortmaker wrote:
> > > On 2016-01-11 06:11 AM, Guenter Roeck wrote:
> > > > On Mon, Jan 11, 2016 at 02:05:36PM +0530, Sudip Mukherjee wrote:
> > > > > On Sat, Jan 09, 2016 at 10:29:08AM -0800, Greg Kroah-Hartman wrote:
> > > > > > On Sat, Jan 09, 2016 at 10:15:35AM -0800, Guenter Roeck wrote:
> > > > > > > If serial/atmel_serial.c is compiled with devicetree enabled, the
<snip>
> >
> > Sudip, one option would be to set up a semi-private mailing list.
> > My build tests now have a dedicated virtual host (kerneltests.org).
> > I could set up a managed list there.
> 
> Perhaps it'd be better to have something like linux-build-failures@vger.kernel.org

yes, much better. But if me and Guenter are the only two members of that
list then it will not look nice. :)

regards
sudip

Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure

[Guenter Roeck]

On 01/13/2016 02:32 AM, Sudip Mukherjee wrote:
> On Tue, Jan 12, 2016 at 09:44:10PM -0800, Joe Perches wrote:
>> On Tue, 2016-01-12 at 21:35 -0800, Guenter Roeck wrote:
>>> On 01/11/2016 07:08 AM, Paul Gortmaker wrote:
>>>> On 2016-01-11 06:11 AM, Guenter Roeck wrote:
>>>>> On Mon, Jan 11, 2016 at 02:05:36PM +0530, Sudip Mukherjee wrote:
>>>>>> On Sat, Jan 09, 2016 at 10:29:08AM -0800, Greg Kroah-Hartman wrote:
>>>>>>> On Sat, Jan 09, 2016 at 10:15:35AM -0800, Guenter Roeck wrote:
>>>>>>>> If serial/atmel_serial.c is compiled with devicetree enabled, the
> <snip>
>>>
>>> Sudip, one option would be to set up a semi-private mailing list.
>>> My build tests now have a dedicated virtual host (kerneltests.org).
>>> I could set up a managed list there.
>>
>> Perhaps it'd be better to have something like linux-build-failures@vger.kernel.org
>
> yes, much better. But if me and Guenter are the only two members of that
> list then it will not look nice. :)
>

Let's see if we can get someone to create a list on vger.kernel.org
(plus an instance of patchwork). If that doesn't work out we can fall back
to kerneltests.org.

Thanks,
Guenter

Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure

[Joe Perches]

On Wed, 2016-01-13 at 16:02 +0530, Sudip Mukherjee wrote:
> On Tue, Jan 12, 2016 at 09:44:10PM -0800, Joe Perches wrote:
> > On Tue, 2016-01-12 at 21:35 -0800, Guenter Roeck wrote:
[]
> > > Sudip, one option would be to set up a semi-private mailing list.
> > > My build tests now have a dedicated virtual host (kerneltests.org).
> > > I could set up a managed list there.
> > 
> > Perhaps it'd be better to have something like linux-build-failures@vger.kernel.org
> 
> yes, much better. But if me and Guenter are the only two members of that
> list then it will not look nice. :)

Likely kbuild-robot output would use it.
That would be better than bcc'ing lkml.

Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure

[Guenter Roeck]

On 01/13/2016 02:32 AM, Sudip Mukherjee wrote:
> On Tue, Jan 12, 2016 at 09:44:10PM -0800, Joe Perches wrote:
>> On Tue, 2016-01-12 at 21:35 -0800, Guenter Roeck wrote:
>>> On 01/11/2016 07:08 AM, Paul Gortmaker wrote:
>>>> On 2016-01-11 06:11 AM, Guenter Roeck wrote:
>>>>> On Mon, Jan 11, 2016 at 02:05:36PM +0530, Sudip Mukherjee wrote:
>>>>>> On Sat, Jan 09, 2016 at 10:29:08AM -0800, Greg Kroah-Hartman wrote:
>>>>>>> On Sat, Jan 09, 2016 at 10:15:35AM -0800, Guenter Roeck wrote:
>>>>>>>> If serial/atmel_serial.c is compiled with devicetree enabled, the
> <snip>
>>>
>>> Sudip, one option would be to set up a semi-private mailing list.
>>> My build tests now have a dedicated virtual host (kerneltests.org).
>>> I could set up a managed list there.
>>
>> Perhaps it'd be better to have something like linux-build-failures@vger.kernel.org
>
> yes, much better. But if me and Guenter are the only two members of that
> list then it will not look nice. :)
>

How about just using kernel-testers@vger.kernel.org ? That list already exists and,
for all practical purposes, has been abandoned.

Guenter

Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure

[Sudip Mukherjee]

On Mon, Jan 18, 2016 at 08:36:38AM -0800, Guenter Roeck wrote:
> On 01/13/2016 02:32 AM, Sudip Mukherjee wrote:
> >On Tue, Jan 12, 2016 at 09:44:10PM -0800, Joe Perches wrote:
> >>On Tue, 2016-01-12 at 21:35 -0800, Guenter Roeck wrote:
> >>>On 01/11/2016 07:08 AM, Paul Gortmaker wrote:
> >>>>On 2016-01-11 06:11 AM, Guenter Roeck wrote:
> >>>>>On Mon, Jan 11, 2016 at 02:05:36PM +0530, Sudip Mukherjee wrote:
> >>>>>>On Sat, Jan 09, 2016 at 10:29:08AM -0800, Greg Kroah-Hartman wrote:
> >>>>>>>On Sat, Jan 09, 2016 at 10:15:35AM -0800, Guenter Roeck wrote:
> >>>>>>>>If serial/atmel_serial.c is compiled with devicetree enabled, the
> ><snip>
> >>>
> >>>Sudip, one option would be to set up a semi-private mailing list.
> >>>My build tests now have a dedicated virtual host (kerneltests.org).
> >>>I could set up a managed list there.
> >>
> >>Perhaps it'd be better to have something like linux-build-failures@vger.kernel.org
> >
> >yes, much better. But if me and Guenter are the only two members of that
> >list then it will not look nice. :)
> >
> 
> How about just using kernel-testers@vger.kernel.org ? That list already exists and,
> for all practical purposes, has been abandoned.

Great. I am subscribing to it.

regards
sudip

Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure

[Guenter Roeck]

On 01/18/2016 09:04 AM, Sudip Mukherjee wrote:
> On Mon, Jan 18, 2016 at 08:36:38AM -0800, Guenter Roeck wrote:
>> On 01/13/2016 02:32 AM, Sudip Mukherjee wrote:
>>> On Tue, Jan 12, 2016 at 09:44:10PM -0800, Joe Perches wrote:
>>>> On Tue, 2016-01-12 at 21:35 -0800, Guenter Roeck wrote:
>>>>> On 01/11/2016 07:08 AM, Paul Gortmaker wrote:
>>>>>> On 2016-01-11 06:11 AM, Guenter Roeck wrote:
>>>>>>> On Mon, Jan 11, 2016 at 02:05:36PM +0530, Sudip Mukherjee wrote:
>>>>>>>> On Sat, Jan 09, 2016 at 10:29:08AM -0800, Greg Kroah-Hartman wrote:
>>>>>>>>> On Sat, Jan 09, 2016 at 10:15:35AM -0800, Guenter Roeck wrote:
>>>>>>>>>> If serial/atmel_serial.c is compiled with devicetree enabled, the
>>> <snip>
>>>>>
>>>>> Sudip, one option would be to set up a semi-private mailing list.
>>>>> My build tests now have a dedicated virtual host (kerneltests.org).
>>>>> I could set up a managed list there.
>>>>
>>>> Perhaps it'd be better to have something like linux-build-failures@vger.kernel.org
>>>
>>> yes, much better. But if me and Guenter are the only two members of that
>>> list then it will not look nice. :)
>>>
>>
>> How about just using kernel-testers@vger.kernel.org ? That list already exists and,
>> for all practical purposes, has been abandoned.
>
> Great. I am subscribing to it.
>

Let's check on the list first. I'll send am e-mail.

Guenter

Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure

[Sudip Mukherjee]

On Mon, Jan 18, 2016 at 09:17:34AM -0800, Guenter Roeck wrote:
> On 01/18/2016 09:04 AM, Sudip Mukherjee wrote:
> >On Mon, Jan 18, 2016 at 08:36:38AM -0800, Guenter Roeck wrote:
> >>On 01/13/2016 02:32 AM, Sudip Mukherjee wrote:
> >>>On Tue, Jan 12, 2016 at 09:44:10PM -0800, Joe Perches wrote:
> >>>>On Tue, 2016-01-12 at 21:35 -0800, Guenter Roeck wrote:
> >>>>>On 01/11/2016 07:08 AM, Paul Gortmaker wrote:
> >>>>>>On 2016-01-11 06:11 AM, Guenter Roeck wrote:
> >>>>>>>On Mon, Jan 11, 2016 at 02:05:36PM +0530, Sudip Mukherjee wrote:
> >>>>>>>>On Sat, Jan 09, 2016 at 10:29:08AM -0800, Greg Kroah-Hartman wrote:
> >>>>>>>>>On Sat, Jan 09, 2016 at 10:15:35AM -0800, Guenter Roeck wrote:
> >>>>>>>>>>If serial/atmel_serial.c is compiled with devicetree enabled, the
> >>><snip>
> >>>>>
> >>>>>Sudip, one option would be to set up a semi-private mailing list.
> >>>>>My build tests now have a dedicated virtual host (kerneltests.org).
> >>>>>I could set up a managed list there.
> >>>>
> >>>>Perhaps it'd be better to have something like linux-build-failures@vger.kernel.org
> >>>
> >>>yes, much better. But if me and Guenter are the only two members of that
> >>>list then it will not look nice. :)
> >>>
> >>
> >>How about just using kernel-testers@vger.kernel.org ? That list already exists and,
> >>for all practical purposes, has been abandoned.
> >
> >Great. I am subscribing to it.
> >
> 
> Let's check on the list first. I'll send am e-mail.

I guess no reply means we can use the list...

regards
sudip

Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure

[Guenter Roeck]

On 01/19/2016 09:51 PM, Sudip Mukherjee wrote:
> On Mon, Jan 18, 2016 at 09:17:34AM -0800, Guenter Roeck wrote:
>> On 01/18/2016 09:04 AM, Sudip Mukherjee wrote:
>>> On Mon, Jan 18, 2016 at 08:36:38AM -0800, Guenter Roeck wrote:
>>>> On 01/13/2016 02:32 AM, Sudip Mukherjee wrote:
>>>>> On Tue, Jan 12, 2016 at 09:44:10PM -0800, Joe Perches wrote:
>>>>>> On Tue, 2016-01-12 at 21:35 -0800, Guenter Roeck wrote:
>>>>>>> On 01/11/2016 07:08 AM, Paul Gortmaker wrote:
>>>>>>>> On 2016-01-11 06:11 AM, Guenter Roeck wrote:
>>>>>>>>> On Mon, Jan 11, 2016 at 02:05:36PM +0530, Sudip Mukherjee wrote:
>>>>>>>>>> On Sat, Jan 09, 2016 at 10:29:08AM -0800, Greg Kroah-Hartman wrote:
>>>>>>>>>>> On Sat, Jan 09, 2016 at 10:15:35AM -0800, Guenter Roeck wrote:
>>>>>>>>>>>> If serial/atmel_serial.c is compiled with devicetree enabled, the
>>>>> <snip>
>>>>>>>
>>>>>>> Sudip, one option would be to set up a semi-private mailing list.
>>>>>>> My build tests now have a dedicated virtual host (kerneltests.org).
>>>>>>> I could set up a managed list there.
>>>>>>
>>>>>> Perhaps it'd be better to have something like linux-build-failures@vger.kernel.org
>>>>>
>>>>> yes, much better. But if me and Guenter are the only two members of that
>>>>> list then it will not look nice. :)
>>>>>
>>>>
>>>> How about just using kernel-testers@vger.kernel.org ? That list already exists and,
>>>> for all practical purposes, has been abandoned.
>>>
>>> Great. I am subscribing to it.
>>>
>>
>> Let's check on the list first. I'll send am e-mail.
>
> I guess no reply means we can use the list...
>

Let's wait until tomorrow; then I'll try to reach the vger majordomo maintainer again
as well as the vger postmaster. We'll need something from there - at the very least
we'll need to get a new list owner. Of course, it would help if someone listening in
to this thread knows how to contact an actual person controlling vger.kernel.org.

Guenter

Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure

[Sudip Mukherjee]

On Tue, Jan 19, 2016 at 10:27:12PM -0800, Guenter Roeck wrote:
> On 01/19/2016 09:51 PM, Sudip Mukherjee wrote:
> >On Mon, Jan 18, 2016 at 09:17:34AM -0800, Guenter Roeck wrote:
> >>On 01/18/2016 09:04 AM, Sudip Mukherjee wrote:
> >>>On Mon, Jan 18, 2016 at 08:36:38AM -0800, Guenter Roeck wrote:
> >>>>On 01/13/2016 02:32 AM, Sudip Mukherjee wrote:
> >>>>>On Tue, Jan 12, 2016 at 09:44:10PM -0800, Joe Perches wrote:
> >>>>>>On Tue, 2016-01-12 at 21:35 -0800, Guenter Roeck wrote:
> >>>>>>>On 01/11/2016 07:08 AM, Paul Gortmaker wrote:
> >>>>>>>>On 2016-01-11 06:11 AM, Guenter Roeck wrote:
> >>>>>>>>>On Mon, Jan 11, 2016 at 02:05:36PM +0530, Sudip Mukherjee wrote:
> >>>>>>>>>>On Sat, Jan 09, 2016 at 10:29:08AM -0800, Greg Kroah-Hartman wrote:
> >>>>>>>>>>>On Sat, Jan 09, 2016 at 10:15:35AM -0800, Guenter Roeck wrote:
> >>>>>>>>>>>>If serial/atmel_serial.c is compiled with devicetree enabled, the
> >>>>><snip>
> >>>>>>>
> >>>>>>>Sudip, one option would be to set up a semi-private mailing list.
> >>>>>>>My build tests now have a dedicated virtual host (kerneltests.org).
> >>>>>>>I could set up a managed list there.
> >>>>>>
> >>>>>>Perhaps it'd be better to have something like linux-build-failures@vger.kernel.org
> >>>>>
> >>>>>yes, much better. But if me and Guenter are the only two members of that
> >>>>>list then it will not look nice. :)
> >>>>>
> >>>>
> >>>>How about just using kernel-testers@vger.kernel.org ? That list already exists and,
> >>>>for all practical purposes, has been abandoned.
> >>>
> >>>Great. I am subscribing to it.
> >>>
> >>
> >>Let's check on the list first. I'll send am e-mail.
> >
> >I guess no reply means we can use the list...
> >
> 
> Let's wait until tomorrow; then I'll try to reach the vger majordomo maintainer again
> as well as the vger postmaster. We'll need something from there - at the very least
> we'll need to get a new list owner. Of course, it would help if someone listening in
> to this thread knows how to contact an actual person controlling vger.kernel.org.

Try reaching "David S. Miller" <davem@davemloft.net>

regards
sudip

Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure

[Sudip Mukherjee]

On Tue, Jan 12, 2016 at 09:35:03PM -0800, Guenter Roeck wrote:
> On 01/11/2016 07:08 AM, Paul Gortmaker wrote:
> >On 2016-01-11 06:11 AM, Guenter Roeck wrote:
> >>On Mon, Jan 11, 2016 at 02:05:36PM +0530, Sudip Mukherjee wrote:
> >>>On Sat, Jan 09, 2016 at 10:29:08AM -0800, Greg Kroah-Hartman wrote:
> >>>>On Sat, Jan 09, 2016 at 10:15:35AM -0800, Guenter Roeck wrote:
<snip>
> >>>
> >>>Hi Guenter,
> >>>Just a thought. It has happended many times that we both have sent
> >>>patches to fix the same build fail. Maybe your patch got applied and
> >>>mine came late or maybe mine was applied and you came late. But I think
> >>>if we have a separate mailing list where people interested to fix and
> >>>monitor build failures will be members and we Cc that list whenever we
> >>>send patch for build fail and then in that case we will know that
> >>>someone else has already sent a patch for this failure and we can invest
> >>>the time in some other problem.
> >>>
> >>
> >>Hi Sudip,
> >>
> >>I agree, it would make sense to have a build(/runtime?)-fixes-only mailing
> >>list. Question though is how to limit noise on such a list and, of course,
> >>where and how to set it up. Any thoughts ?
> >
> >Since most (all?) of these kind of fails are on linux-next, why not
> 
> Most or many, but not all.
> 
> >do what everyone else does, and report the fail there and/or ensure
> >the fix is cc'd there?   Before I waste time trying to fix sth on
> >linux-next, I always google for the error msg and many times that
> >leads me to a lkml or linux-next post where it was reported and
> >fixed already.
> 
> Many times, Sudip and I end up fixing problems literally in parallel,
> and it happened quite often lately that we do send patches in parallel.

sometimes it was a difference of few minutes.

> Even if I do a Google search for an error message, it happens quite
> often that I get no results, yet the fix is already out there on
> some list.

google will take some time to index it.

> 
> Sudip, one option would be to set up a semi-private mailing list.
> My build tests now have a dedicated virtual host (kerneltests.org).
> I could set up a managed list there.

yes, fine with me. As long as we can share the information that one of
us has already sent the fix.

regards
sudip