From: "Maarten Brock" <m.brock@vanmierlo.com>
To: linux-serial@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Sean Nyekjaer <sean.nyekjaer@prevas.dk>,
Josh Cartwright <joshc@ni.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-rt-users@vger.kernel.org,
Jon Ringle <jringle@gridpoint.com>
Subject: Re: [PATCH] tty: serial: sc16is7xx: implemented our own oneshot-like handling
Date: Sun, 13 Mar 2016 20:05:58 +0100 [thread overview]
Message-ID: <20160313200558.06543fce@kerio.vanmierlo.com> (raw)
I also wonder why this driver doesn't use threaded interrupts, just like the
MAX310x driver it is based upon.
Maarten
> This driver should use a threaded interrupt instead of trying to emulate it
> via dis/enable_irq and a worker thread.
>
> Then you simply call c16is7xx_port_irq() right from the interrupt routine
> and the core code deals with the interrupt mask/unmask automatically.
>
> Thanks,
>
> tglx
next reply other threads:[~2016-03-13 19:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-13 19:05 Maarten Brock [this message]
2016-03-14 6:17 ` [PATCH] tty: serial: sc16is7xx: implemented our own oneshot-like handling Sean Nyekjær
-- strict thread matches above, loose matches on Subject: below --
2016-03-11 10:34 Sean Nyekjaer
2016-03-11 10:36 ` Sean Nyekjær
2016-03-11 11:21 ` Sebastian Andrzej Siewior
2016-03-11 11:29 ` Sean Nyekjær
2016-03-11 11:33 ` Sean Nyekjær
2016-03-11 16:43 ` Greg Kroah-Hartman
2016-03-13 10:25 ` Thomas Gleixner
2016-03-14 6:21 ` Sean Nyekjær
2016-03-14 8:48 ` Thomas Gleixner
2016-03-14 23:13 ` Jakub Kiciński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160313200558.06543fce@kerio.vanmierlo.com \
--to=m.brock@vanmierlo.com \
--cc=gregkh@linuxfoundation.org \
--cc=joshc@ni.com \
--cc=jringle@gridpoint.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sean.nyekjaer@prevas.dk \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).