From: Jonathan Corbet <corbet@lwn.net>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
Peter Hurley <peter@hurleysoftware.com>,
Russell King <rmk@arm.linux.org.uk>,
linux-serial@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 4/4] serial: doc: .break_ctl() may sleep
Date: Fri, 15 Apr 2016 16:01:04 -0600 [thread overview]
Message-ID: <20160415160104.6aed0770@lwn.net> (raw)
In-Reply-To: <1460624891-8389-5-git-send-email-geert+renesas@glider.be>
On Thu, 14 Apr 2016 11:08:11 +0200
Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> As mutex_lock() must not be called with interrupts disabled,
> .break_ctl() may sleep.
So I've applied the first three to the docs tree, but this one stopped
me. The changelog doesn't really say why the patch is correct; what we
really need to know is that break_ctl() won't be called in atomic
context. I'm assuming that's the case, but if it truly is, can I get a
version with a changelog saying that?
Thanks,
jon
next prev parent reply other threads:[~2016-04-15 22:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 9:08 [PATCH 0/4] serial: doc: Low Level Serial API Documentation Improvements (take two) Geert Uytterhoeven
2016-04-14 9:08 ` [PATCH 1/4] serial: doc: Re-add paragraph documenting uart_console_write() Geert Uytterhoeven
2016-04-14 9:08 ` [PATCH 2/4] serial: doc: .(un)throttle() depends on hardware assisted flow control Geert Uytterhoeven
2016-04-14 9:08 ` [PATCH 3/4] serial: doc: .(un)throttle() are serialized by the tty layer Geert Uytterhoeven
2016-04-14 9:08 ` [PATCH 4/4] serial: doc: .break_ctl() may sleep Geert Uytterhoeven
2016-04-15 22:01 ` Jonathan Corbet [this message]
2016-04-15 22:31 ` Peter Hurley
2016-04-15 22:41 ` Jonathan Corbet
2016-04-15 23:07 ` Peter Hurley
2016-04-16 16:47 ` Jonathan Corbet
2016-04-18 8:24 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160415160104.6aed0770@lwn.net \
--to=corbet@lwn.net \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).