From: Grant Edwards <grant.b.edwards@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Peter Hurley <peter@hurleysoftware.com>,
Jiri Slaby <jslaby@suse.cz>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 0/8] Replace kernel-defined ASYNC_ bits
Date: Thu, 28 Apr 2016 15:44:15 -0500 [thread overview]
Message-ID: <20160428204415.GA21183@grante> (raw)
In-Reply-To: <20160428203643.GA13542@kroah.com>
On Thu, Apr 28, 2016 at 01:36:43PM -0700, Greg Kroah-Hartman wrote:
> On Sat, Apr 09, 2016 at 05:53:19PM -0700, Peter Hurley wrote:
> > As outlined in my January email ("RFC: out-of-tree tty driver breakage"),
> > the tty/serial core uses 5 bits in the tty_port.flags field to manage
> > state. They are:
[...]
> > The last patch of the series purposefully breaks out-of-tree driver
> > builds to ensure they update state test/change methods to the helpers
> > instead.
> >
> > REQUIRES: "tty: Replace TTY_IO_ERROR bit tests with tty_io_error()"
> > "tty: Replace TTY_THROTTLED bit tests with tty_throttled()"
>
> Wonderful, thanks for doing this work.
And particular thanks from us out-of-tree driver maintainers for
making the breakage apparent. It always sucks when a change goes in
under our radar that causes breakage without even causing a compiler
warning. [Yea, I know if the drivers were in-tree, this wouldn't be a
problem.]
--
Grant
prev parent reply other threads:[~2016-04-28 20:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-10 0:53 [PATCH 0/8] Replace kernel-defined ASYNC_ bits Peter Hurley
2016-04-10 0:53 ` [PATCH 1/8] tty: Define ASYNC_ replacement bits Peter Hurley
2016-04-10 0:53 ` [PATCH 2/8] tty: Replace ASYNC_CTS_FLOW bit and update atomically Peter Hurley
2016-04-10 0:53 ` [PATCH 3/8] tty: Replace ASYNC_NORMAL_ACTIVE " Peter Hurley
2016-04-10 0:53 ` [PATCH 4/8] tty: Replace ASYNC_CHECK_CD " Peter Hurley
2016-04-10 0:53 ` [PATCH 5/8] tty: Replace ASYNC_SUSPENDED bit " Peter Hurley
2016-04-10 0:53 ` [PATCH 6/8] tty: Replace ASYNC_INITIALIZED " Peter Hurley
2016-04-29 10:34 ` Johan Hovold
2016-04-10 0:53 ` [PATCH 7/8] tty: mxser: Remove unused ASYNC_SHARE_IRQ flag Peter Hurley
2016-04-10 0:53 ` [PATCH 8/8] tty: core: Undefine ASYNC_* flags superceded by TTY_PORT* flags Peter Hurley
2016-04-28 20:36 ` [PATCH 0/8] Replace kernel-defined ASYNC_ bits Greg Kroah-Hartman
2016-04-28 20:44 ` Grant Edwards [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160428204415.GA21183@grante \
--to=grant.b.edwards@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).