From: David Sterba <dsterba@suse.cz>
To: Jiri Slaby <jslaby@suse.cz>
Cc: gregkh@linuxfoundation.org, Jiri Kosina <jikos@kernel.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH 1/7] tty: ipwireless, cleanup TIOCGSERIAL
Date: Mon, 9 May 2016 09:32:04 +0200 [thread overview]
Message-ID: <20160509073204.GI29353@suse.cz> (raw)
In-Reply-To: <1462777919-10367-1-git-send-email-jslaby@suse.cz>
On Mon, May 09, 2016 at 09:11:53AM +0200, Jiri Slaby wrote:
> In ipwireless_get_serial_info, struct serial_struct is memset to 0 and
> then some members set to 0 explicitly.
>
> Remove the latter as it is obviously superfluous.
>
> And remove the retinfo check against NULL. copy_to_user will take care
> of that.
>
> Part of hub6 cleanup series.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Jiri Kosina <jikos@kernel.org>
> Cc: David Sterba <dsterba@suse.com>
Acked-by: David Sterba <dsterba@suse.com>
prev parent reply other threads:[~2016-05-09 7:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 7:11 [PATCH 1/7] tty: ipwireless, cleanup TIOCGSERIAL Jiri Slaby
2016-05-09 7:11 ` [PATCH 2/7] net: ircomm, " Jiri Slaby
2016-05-10 18:16 ` David Miller
2016-05-09 7:11 ` [PATCH 3/7] tty: cyclades+mxser, do not initialize to zero Jiri Slaby
2016-05-09 7:11 ` [PATCH 4/7] tty: frv, remove unused serial macros Jiri Slaby
2016-05-09 7:11 ` [PATCH 5/7] tty: stop defining STD_COM_FLAGS in drivers Jiri Slaby
2016-05-09 7:11 ` [PATCH 6/7] tty: 8250, drop unused members from struct old_serial_port Jiri Slaby
2016-05-09 7:11 ` [PATCH 7/7] tty: 8250, kill DEBUG_INTR Jiri Slaby
2016-05-09 7:32 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160509073204.GI29353@suse.cz \
--to=dsterba@suse.cz \
--cc=gregkh@linuxfoundation.org \
--cc=jikos@kernel.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).