From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: zengzhaoxiu@163.com
Cc: linux-kernel@vger.kernel.org,
Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com>,
Jiri Slaby <jslaby@suse.com>,
linux-serial@vger.kernel.org
Subject: Re: [patch V4 27/31] serial: use parity32 in max3100
Date: Sat, 25 Jun 2016 10:25:00 -0700 [thread overview]
Message-ID: <20160625172500.GA18790@kroah.com> (raw)
In-Reply-To: <1462958587-25987-1-git-send-email-zengzhaoxiu@163.com>
On Wed, May 11, 2016 at 05:23:07PM +0800, zengzhaoxiu@163.com wrote:
> From: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com>
>
> Signed-off-by: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/tty/serial/max3100.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/max3100.c b/drivers/tty/serial/max3100.c
> index 5c4c280..a0cc84a 100644
> --- a/drivers/tty/serial/max3100.c
> +++ b/drivers/tty/serial/max3100.c
> @@ -155,7 +155,7 @@ static int max3100_do_parity(struct max3100_port *s, u16 c)
> else
> c &= 0xff;
>
> - parity = parity ^ (hweight8(c) & 1);
> + parity ^= parity8(c);
Your subject does not match the patch, and there is no changelog text so
I can't take it :(
Please fix up.
greg k-h
next prev parent reply other threads:[~2016-06-25 17:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1462955158-28394-1-git-send-email-zengzhaoxiu@163.com>
2016-05-11 9:23 ` [patch V4 27/31] serial: use parity32 in max3100 zengzhaoxiu
2016-06-25 17:25 ` Greg Kroah-Hartman [this message]
2016-06-29 14:57 ` [patch V4 27/31] serial: use parity8 " zengzhaoxiu
2016-06-29 16:43 ` Greg KH
2016-06-29 17:25 ` zengzhaoxiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160625172500.GA18790@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=zengzhaoxiu@163.com \
--cc=zhaoxiu.zeng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).