* [patch V4 27/31] serial: use parity32 in max3100
[not found] <1462955158-28394-1-git-send-email-zengzhaoxiu@163.com>
@ 2016-05-11 9:23 ` zengzhaoxiu
2016-06-25 17:25 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: zengzhaoxiu @ 2016-05-11 9:23 UTC (permalink / raw)
To: linux-kernel; +Cc: Zhaoxiu Zeng, Greg Kroah-Hartman, Jiri Slaby, linux-serial
From: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com>
Signed-off-by: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/tty/serial/max3100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/max3100.c b/drivers/tty/serial/max3100.c
index 5c4c280..a0cc84a 100644
--- a/drivers/tty/serial/max3100.c
+++ b/drivers/tty/serial/max3100.c
@@ -155,7 +155,7 @@ static int max3100_do_parity(struct max3100_port *s, u16 c)
else
c &= 0xff;
- parity = parity ^ (hweight8(c) & 1);
+ parity ^= parity8(c);
return parity;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [patch V4 27/31] serial: use parity32 in max3100
2016-05-11 9:23 ` [patch V4 27/31] serial: use parity32 in max3100 zengzhaoxiu
@ 2016-06-25 17:25 ` Greg Kroah-Hartman
2016-06-29 14:57 ` [patch V4 27/31] serial: use parity8 " zengzhaoxiu
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2016-06-25 17:25 UTC (permalink / raw)
To: zengzhaoxiu; +Cc: linux-kernel, Zhaoxiu Zeng, Jiri Slaby, linux-serial
On Wed, May 11, 2016 at 05:23:07PM +0800, zengzhaoxiu@163.com wrote:
> From: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com>
>
> Signed-off-by: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/tty/serial/max3100.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/max3100.c b/drivers/tty/serial/max3100.c
> index 5c4c280..a0cc84a 100644
> --- a/drivers/tty/serial/max3100.c
> +++ b/drivers/tty/serial/max3100.c
> @@ -155,7 +155,7 @@ static int max3100_do_parity(struct max3100_port *s, u16 c)
> else
> c &= 0xff;
>
> - parity = parity ^ (hweight8(c) & 1);
> + parity ^= parity8(c);
Your subject does not match the patch, and there is no changelog text so
I can't take it :(
Please fix up.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [patch V4 27/31] serial: use parity8 in max3100
2016-06-25 17:25 ` Greg Kroah-Hartman
@ 2016-06-29 14:57 ` zengzhaoxiu
2016-06-29 16:43 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: zengzhaoxiu @ 2016-06-29 14:57 UTC (permalink / raw)
To: gregkh, jslaby, linux-serial, linux-kernel; +Cc: Zhaoxiu Zeng
From: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com>
Signed-off-by: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/tty/serial/max3100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/max3100.c b/drivers/tty/serial/max3100.c
index 5c4c280..a0cc84a 100644
--- a/drivers/tty/serial/max3100.c
+++ b/drivers/tty/serial/max3100.c
@@ -155,7 +155,7 @@ static int max3100_do_parity(struct max3100_port *s, u16 c)
else
c &= 0xff;
- parity = parity ^ (hweight8(c) & 1);
+ parity ^= parity8(c);
return parity;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [patch V4 27/31] serial: use parity8 in max3100
2016-06-29 14:57 ` [patch V4 27/31] serial: use parity8 " zengzhaoxiu
@ 2016-06-29 16:43 ` Greg KH
2016-06-29 17:25 ` zengzhaoxiu
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2016-06-29 16:43 UTC (permalink / raw)
To: zengzhaoxiu; +Cc: jslaby, linux-serial, linux-kernel, Zhaoxiu Zeng
On Wed, Jun 29, 2016 at 10:57:08PM +0800, zengzhaoxiu@163.com wrote:
> From: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com>
>
> Signed-off-by: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
I acked this? I don't remember doing that...
Again, I can't take patches without any changelog text, sorry. Please
take my ack off of this patch.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* [patch V4 27/31] serial: use parity8 in max3100
2016-06-29 16:43 ` Greg KH
@ 2016-06-29 17:25 ` zengzhaoxiu
0 siblings, 0 replies; 5+ messages in thread
From: zengzhaoxiu @ 2016-06-29 17:25 UTC (permalink / raw)
To: gregkh, jslaby, linux-serial, linux-kernel; +Cc: Zhaoxiu Zeng
From: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com>
Use parity8(c) instead "hweight8(c) & 1" to improve readability,
and improve performance on some CPUs that without popcount support.
Signed-off-by: Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com>
---
drivers/tty/serial/max3100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/max3100.c b/drivers/tty/serial/max3100.c
index 5c4c280..a0cc84a 100644
--- a/drivers/tty/serial/max3100.c
+++ b/drivers/tty/serial/max3100.c
@@ -155,7 +155,7 @@ static int max3100_do_parity(struct max3100_port *s, u16 c)
else
c &= 0xff;
- parity = parity ^ (hweight8(c) & 1);
+ parity ^= parity8(c);
return parity;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-06-29 17:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1462955158-28394-1-git-send-email-zengzhaoxiu@163.com>
2016-05-11 9:23 ` [patch V4 27/31] serial: use parity32 in max3100 zengzhaoxiu
2016-06-25 17:25 ` Greg Kroah-Hartman
2016-06-29 14:57 ` [patch V4 27/31] serial: use parity8 " zengzhaoxiu
2016-06-29 16:43 ` Greg KH
2016-06-29 17:25 ` zengzhaoxiu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).