From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: linux-arm-kernel@lists.infradead.org,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Boris BREZILLON <boris.brezillon@free-electrons.com>,
Ludovic Desroches <ludovic.desroches@atmel.com>
Subject: Re: [PATCH 4/4] tty/serial: atmel: enforce tasklet init and termination sequences
Date: Sat, 25 Jun 2016 13:39:59 -0700 [thread overview]
Message-ID: <20160625203959.GA22761@kroah.com> (raw)
In-Reply-To: <5a52e1fbd8ec126bebfcd00f35bfe5af605ee914.1466157015.git.nicolas.ferre@atmel.com>
On Fri, Jun 17, 2016 at 12:05:49PM +0200, Nicolas Ferre wrote:
> As some race conditions are identified in the termination process of tasklets,
> enforce the atmel_shutdown() sequence. This way we make sure that no new
> tasklets or software timer are scheduled during shutdown process.
>
> An atomic flag is positioned to give this information throughout the code.
>
> We also remove tasklet_disable() calls that were leading to deadlocks while
> stopping the driver. A simpler init/kill sequence is used.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> drivers/tty/serial/atmel_serial.c | 61 ++++++++++++++++++++++++---------------
> 1 file changed, 38 insertions(+), 23 deletions(-)
You obviously didn't even test build this patch, as it breaks the build :(
please be more careful...
greg k-h
next prev parent reply other threads:[~2016-06-25 20:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 10:05 [PATCH 0/4] tty/serial: atmel: rework tasklets and shutdown sequence Nicolas Ferre
2016-06-17 10:05 ` [RESEND PATCH 1/4] tty/serial: atmel: re-integrate status check in irq handler Nicolas Ferre
2016-06-17 10:05 ` [RESEND PATCH 2/4] tty/serial: atmel: split tx and rx paths Nicolas Ferre
2016-06-17 10:05 ` [RESEND PATCH 3/4] tty/serial: atmel: add comment for the ring buffer size macro Nicolas Ferre
2016-06-17 10:05 ` [PATCH 4/4] tty/serial: atmel: enforce tasklet init and termination sequences Nicolas Ferre
2016-06-25 20:39 ` Greg Kroah-Hartman [this message]
2016-06-26 7:44 ` [PATCH v2] " Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160625203959.GA22761@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).