From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-serial@vger.kernel.org,
Peter Hurley <peter@hurleysoftware.com>,
Yegor Yefremov <yegorslists@googlemail.com>,
linux-kernel@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH v1 1/1] Revert "tty/serial/8250: use mctrl_gpio helpers"
Date: Mon, 22 Aug 2016 11:38:38 +0300 [thread overview]
Message-ID: <20160822083838.GA9065@kuha.fi.intel.com> (raw)
In-Reply-To: <1471349214-69793-1-git-send-email-andriy.shevchenko@linux.intel.com>
Hi,
On Tue, Aug 16, 2016 at 03:06:54PM +0300, Andy Shevchenko wrote:
> Serial console is broken in v4.8-rcX. Mika and I independently bisected down to
> commit 4ef03d328769 ("tty/serial/8250: use mctrl_gpio helpers").
>
> Since neither author nor anyone else didn't propose a solution we better revert
> it for now.
>
> This reverts commit 4ef03d328769eddbfeca1f1c958fdb181a69c341.
Maybe you should have explained the problem in the commit message.
I just hit the issue, and can confirm that this patch fixes it. So
basically 8250 is broken in v4.8. Shouldn't this have "Cc: stable.."
tag?
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Link: https://lkml.kernel.org/r/20160809130229.GN1729@lahna.fi.intel.com
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
In any case, FWIW:
Tested-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Thanks,
--
heikki
next prev parent reply other threads:[~2016-08-22 8:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 12:06 [PATCH v1 1/1] Revert "tty/serial/8250: use mctrl_gpio helpers" Andy Shevchenko
2016-08-17 9:21 ` Mika Westerberg
2016-08-22 8:38 ` Heikki Krogerus [this message]
2016-08-29 7:07 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160822083838.GA9065@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=peter@hurleysoftware.com \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).