From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: linux-serial@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: 8250_pci: Use symbolic constants for EXAR's MPIO registers
Date: Wed, 31 Aug 2016 15:58:39 +0200 [thread overview]
Message-ID: <20160831135839.GB13298@kroah.com> (raw)
In-Reply-To: <055cacef-1ab0-0541-030d-d2313763cb2e@siemens.com>
On Tue, Jul 26, 2016 at 10:44:56PM +0200, Jan Kiszka wrote:
> On 2016-07-26 22:14, Greg Kroah-Hartman wrote:
> > On Tue, Jul 26, 2016 at 09:50:37PM +0200, Jan Kiszka wrote:
> >> Less magics that only require comments.
> >>
> >> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> >> ---
> >> drivers/tty/serial/8250/8250_pci.c | 42 +++++++++++++++++++-------------------
> >> include/uapi/linux/serial_reg.h | 13 ++++++++++++
> >> 2 files changed, 34 insertions(+), 21 deletions(-)
> >>
> >> diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
> >> index c1d4a8f..7f77060 100644
> >> --- a/drivers/tty/serial/8250/8250_pci.c
> >> +++ b/drivers/tty/serial/8250/8250_pci.c
> >> @@ -1796,18 +1796,18 @@ pci_xr17v35x_setup(struct serial_private *priv,
> >> * Setup Multipurpose Input/Output pins.
> >> */
> >> if (idx == 0) {
> >> - writeb(0x00, p + 0x8f); /*MPIOINT[7:0]*/
> >> - writeb(0x00, p + 0x90); /*MPIOLVL[7:0]*/
> >> - writeb(0x00, p + 0x91); /*MPIO3T[7:0]*/
> >> - writeb(0x00, p + 0x92); /*MPIOINV[7:0]*/
> >> - writeb(0x00, p + 0x93); /*MPIOSEL[7:0]*/
> >> - writeb(0x00, p + 0x94); /*MPIOOD[7:0]*/
> >> - writeb(0x00, p + 0x95); /*MPIOINT[15:8]*/
> >> - writeb(0x00, p + 0x96); /*MPIOLVL[15:8]*/
> >> - writeb(0x00, p + 0x97); /*MPIO3T[15:8]*/
> >> - writeb(0x00, p + 0x98); /*MPIOINV[15:8]*/
> >> - writeb(0x00, p + 0x99); /*MPIOSEL[15:8]*/
> >> - writeb(0x00, p + 0x9a); /*MPIOOD[15:8]*/
> >> + writeb(0x00, p + UART_EXAR_MPIOINT_7_0);
> >> + writeb(0x00, p + UART_EXAR_MPIOLVL_7_0);
> >> + writeb(0x00, p + UART_EXAR_MPIO3T_7_0);
> >> + writeb(0x00, p + UART_EXAR_MPIOINV_7_0);
> >> + writeb(0x00, p + UART_EXAR_MPIOSEL_7_0);
> >> + writeb(0x00, p + UART_EXAR_MPIOOD_7_0);
> >> + writeb(0x00, p + UART_EXAR_MPIOINT_15_8);
> >> + writeb(0x00, p + UART_EXAR_MPIOLVL_15_8);
> >> + writeb(0x00, p + UART_EXAR_MPIO3T_15_8);
> >> + writeb(0x00, p + UART_EXAR_MPIOINV_15_8);
> >> + writeb(0x00, p + UART_EXAR_MPIOSEL_15_8);
> >> + writeb(0x00, p + UART_EXAR_MPIOOD_15_8);
> >> }
> >> writeb(0x00, p + UART_EXAR_8XMODE);
> >> writeb(UART_FCTR_EXAR_TRGD, p + UART_EXAR_FCTR);
> >> @@ -1843,20 +1843,20 @@ pci_fastcom335_setup(struct serial_private *priv,
> >> switch (priv->dev->device) {
> >> case PCI_DEVICE_ID_COMMTECH_4222PCI335:
> >> case PCI_DEVICE_ID_COMMTECH_4224PCI335:
> >> - writeb(0x78, p + 0x90); /* MPIOLVL[7:0] */
> >> - writeb(0x00, p + 0x92); /* MPIOINV[7:0] */
> >> - writeb(0x00, p + 0x93); /* MPIOSEL[7:0] */
> >> + writeb(0x78, p + UART_EXAR_MPIOLVL_7_0);
> >> + writeb(0x00, p + UART_EXAR_MPIOINV_7_0);
> >> + writeb(0x00, p + UART_EXAR_MPIOSEL_7_0);
> >> break;
> >> case PCI_DEVICE_ID_COMMTECH_2324PCI335:
> >> case PCI_DEVICE_ID_COMMTECH_2328PCI335:
> >> - writeb(0x00, p + 0x90); /* MPIOLVL[7:0] */
> >> - writeb(0xc0, p + 0x92); /* MPIOINV[7:0] */
> >> - writeb(0xc0, p + 0x93); /* MPIOSEL[7:0] */
> >> + writeb(0x00, p + UART_EXAR_MPIOLVL_7_0);
> >> + writeb(0xc0, p + UART_EXAR_MPIOINV_7_0);
> >> + writeb(0xc0, p + UART_EXAR_MPIOSEL_7_0);
> >> break;
> >> }
> >> - writeb(0x00, p + 0x8f); /* MPIOINT[7:0] */
> >> - writeb(0x00, p + 0x91); /* MPIO3T[7:0] */
> >> - writeb(0x00, p + 0x94); /* MPIOOD[7:0] */
> >> + writeb(0x00, p + UART_EXAR_MPIOINT_7_0);
> >> + writeb(0x00, p + UART_EXAR_MPIO3T_7_0);
> >> + writeb(0x00, p + UART_EXAR_MPIOOD_7_0);
> >> }
> >> writeb(0x00, p + UART_EXAR_8XMODE);
> >> writeb(UART_FCTR_EXAR_TRGD, p + UART_EXAR_FCTR);
> >> diff --git a/include/uapi/linux/serial_reg.h b/include/uapi/linux/serial_reg.h
> >> index 1e5ac4e7..d176448 100644
> >> --- a/include/uapi/linux/serial_reg.h
> >> +++ b/include/uapi/linux/serial_reg.h
> >> @@ -376,5 +376,18 @@
> >> #define UART_EXAR_TXTRG 0x0a /* Tx FIFO trigger level write-only */
> >> #define UART_EXAR_RXTRG 0x0b /* Rx FIFO trigger level write-only */
> >>
> >> +#define UART_EXAR_MPIOINT_7_0 0x8f /* MPIOINT[7:0] */
> >> +#define UART_EXAR_MPIOLVL_7_0 0x90 /* MPIOLVL[7:0] */
> >> +#define UART_EXAR_MPIO3T_7_0 0x91 /* MPIO3T[7:0] */
> >> +#define UART_EXAR_MPIOINV_7_0 0x92 /* MPIOINV[7:0] */
> >> +#define UART_EXAR_MPIOSEL_7_0 0x93 /* MPIOSEL[7:0] */
> >> +#define UART_EXAR_MPIOOD_7_0 0x94 /* MPIOOD[7:0] */
> >> +#define UART_EXAR_MPIOINT_15_8 0x95 /* MPIOINT[15:8] */
> >> +#define UART_EXAR_MPIOLVL_15_8 0x96 /* MPIOLVL[15:8] */
> >> +#define UART_EXAR_MPIO3T_15_8 0x97 /* MPIO3T[15:8] */
> >> +#define UART_EXAR_MPIOINV_15_8 0x98 /* MPIOINV[15:8] */
> >> +#define UART_EXAR_MPIOSEL_15_8 0x99 /* MPIOSEL[15:8] */
> >> +#define UART_EXAR_MPIOOD_15_8 0x9a /* MPIOOD[15:8] */
> >> +
> >
> > Why are you putting these in a user api file? I know it matches the
> > existing ones, but is this something that userspace really cares about?
>
> Very valid question, and I was wondering the same. Maybe 95% of this
> header is just lazy leftover from 607ca46e97.
>
> I'm fine with starting off some include/linux/serial_reg.h, provided
> someone gives me a hint what should be moved - I'm not very familiar
> with the serial kernel ABI. Or I just start it off with those defines
> above. You choose.
Just put them in the driver itself for now, no need to add them when no
one is asking for them :)
thanks,
greg k-h
next prev parent reply other threads:[~2016-08-31 13:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 19:50 [PATCH] serial: 8250_pci: Use symbolic constants for EXAR's MPIO registers Jan Kiszka
2016-07-26 20:14 ` Greg Kroah-Hartman
2016-07-26 20:44 ` Jan Kiszka
2016-08-31 13:58 ` Greg Kroah-Hartman [this message]
2016-09-19 4:56 ` [PATCH v2] " Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831135839.GB13298@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox