From: Sebastian Andrzej Siewior <sebastian.siewior@linutronix.de>
To: Josh Cartwright <joshc@ni.com>
Cc: Jakub Kicinski <moorray3@wp.pl>,
linux-serial@vger.kernel.org, linux-rt-users@vger.kernel.org,
Sean Nyekjaer <sean.nyekjaer@prevas.dk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sc16is7xx: drop bogus use of IRQF_ONESHOT
Date: Fri, 9 Sep 2016 15:14:32 +0200 [thread overview]
Message-ID: <20160909131432.baydlypki3wch5nv@linutronix.de> (raw)
In-Reply-To: <1455816372-13989-1-git-send-email-joshc@ni.com>
On 2016-02-18 11:26:12 [-0600], Josh Cartwright wrote:
> The use of IRQF_ONESHOT when registering an interrupt handler with
> request_irq() is non-sensical.
>
> Not only that, it also prevents the handler from being threaded when it
> otherwise should be w/ IRQ_FORCED_THREADING is enabled. This causes the
> following deadlock observed by Sean Nyekjaer on -rt:
So we this patch
http://lkml.iu.edu/hypermail/linux/kernel/1602.2/02637.html
sitting in -RT. Then someone posted
http://www.spinics.net/lists/linux-rt-users/msg14975.html
which depends on it.
Before I was are of the first patch, I posted
http://www.spinics.net/lists/linux-rt-users/msg14666.html
and nobody seems to care if anything of this gets merged upstream
where it belongs. Could some please carry this to Greg upstream?
Sebastian
next prev parent reply other threads:[~2016-09-09 13:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1455523133-29895-1-git-send-email-sean.nyekjaer@prevas.dk>
[not found] ` <20160215220810.11529101@laptop>
[not found] ` <56C2D1A7.1030908@prevas.dk>
[not found] ` <20160216210250.34c2f07f@laptop>
[not found] ` <56C41FA5.4010605@prevas.dk>
2016-02-17 21:54 ` [PATCH] sc16is7xx: switch to threaded irq for fixing RT issues Jakub Kicinski
2016-02-17 23:25 ` Josh Cartwright
2016-02-18 7:29 ` Sean Nyekjær
2016-02-18 8:46 ` Jakub Kicinski
2016-02-18 17:26 ` [PATCH] sc16is7xx: drop bogus use of IRQF_ONESHOT Josh Cartwright
2016-03-08 12:43 ` Sean Nyekjær
2016-09-09 13:14 ` Sebastian Andrzej Siewior [this message]
2016-10-03 15:14 [PATCH] sc16is7xx: Drop " Julia Cartwright
2016-10-13 0:48 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160909131432.baydlypki3wch5nv@linutronix.de \
--to=sebastian.siewior@linutronix.de \
--cc=joshc@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=moorray3@wp.pl \
--cc=sean.nyekjaer@prevas.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).