From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH] tty: amba-pl011: uart_amba_port is not available with earlycon function Date: Tue, 20 Sep 2016 21:05:04 +0800 Message-ID: <20160920130504.GF3744@tiger> References: <1474092878-30034-1-git-send-email-shawn.guo@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1474092878-30034-1-git-send-email-shawn.guo@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sudeep Holla Cc: Peter Hurley , Jason Liu , Greg Kroah-Hartman , Timur Tabi , xie.baoyou@zte.com.cn, Russell King - ARM Linux , linux-serial@vger.kernel.org, Andre Przywara , Jun Nie , linux-arm-kernel@lists.infradead.org List-Id: linux-serial@vger.kernel.org On Sat, Sep 17, 2016 at 02:14:38PM +0800, Shawn Guo wrote: > Commit 0e125a5facf8 ("tty: amba-pl011: define flag register bits for ZTE > device") changes earlycon function pl011_putc() to use a pointer to > uart_amba_port. This causes a regression when earlycon is enabled, > because uart_amba_port is not available yet at earlycon time. Let's > revert the change on pl011_putc() to fix the regression. > > The earlycon support for ZTE device can probably be added later by > declaring a new earlycon setup function with a vendor specific > compatible. > > Reported-by: Sudeep Holla > Fixes: 0e125a5facf8 ("tty: amba-pl011: define flag register bits for ZTE device") > Signed-off-by: Shawn Guo Hi Sudeep, Can you please confirm if the patch fixes your problem, so that Greg knows whether it should be applied? Thanks. Shawn