From: Krzysztof Kozlowski <krzk@kernel.org>
To: 남영민 <youngmin.nam@samsung.com>
Cc: gregkh@linuxfoundation.org, jslaby@suse.com,
linux-serial@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] serial: samsung: add clock controls in s3c24xx_serial_resume_noirq()
Date: Fri, 30 Sep 2016 12:34:34 +0200 [thread overview]
Message-ID: <20160930103434.GA4713@kozik-lap> (raw)
In-Reply-To: <000d01d218c5$3069cdf0$913d69d0$@samsung.com>
On Tue, Sep 27, 2016 at 10:43:54PM +0900, 남영민 wrote:
> This patch adds clock controls in s3c24xx_serial_resume_noirq()
> to set S3C64XX_UINTM register.
Code looks correct but the commit message is bogus. It does not bring
any benefit over the code, not mentioning that it is quite cryptic (what
does the "clock controls" mean?).
Just describe here WHAT is the problem and WHY the fix is needed.
Best regards,
Krzysztof
>
> Signed-off-by: Youngmin Nam <youngmin.nam@samsung.com>
> ---
> drivers/tty/serial/samsung.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> index ae2095a..97f7b3b 100644
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/tty/serial/samsung.c
> @@ -1921,6 +1921,7 @@ static int s3c24xx_serial_resume(struct device *dev)
> static int s3c24xx_serial_resume_noirq(struct device *dev)
> {
> struct uart_port *port = s3c24xx_dev_to_port(dev);
> + struct s3c24xx_uart_port *ourport = to_ourport(port);
>
> if (port) {
> /* restore IRQ mask */
> @@ -1930,7 +1931,9 @@ static int s3c24xx_serial_resume_noirq(struct device *dev)
> uintm &= ~S3C64XX_UINTM_TXD_MSK;
> if (rx_enabled(port))
> uintm &= ~S3C64XX_UINTM_RXD_MSK;
> + clk_prepare_enable(ourport->clk);
> wr_regl(port, S3C64XX_UINTM, uintm);
> + clk_disable_unprepare(ourport->clk);
> }
> }
>
> --
> 2.8.1
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-09-30 10:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 13:43 [PATCH] serial: samsung: add clock controls in s3c24xx_serial_resume_noirq() 남영민
2016-09-30 10:34 ` Krzysztof Kozlowski [this message]
2016-10-04 5:04 ` 남영민
2017-01-26 13:40 ` Tobias Jakobi
2017-02-01 9:45 ` 남영민
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160930103434.GA4713@kozik-lap \
--to=krzk@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=youngmin.nam@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).