From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v6 RESEND] serial: rewrite pxa2xx-uart to use 8250_core Date: Thu, 6 Oct 2016 09:15:35 +0200 Message-ID: <20161006071535.GA17007@kroah.com> References: <1474993396-525-1-git-send-email-robert.jarzmik@free.fr> <87shsa804g.fsf@belgarion.home> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <87shsa804g.fsf@belgarion.home> Sender: linux-kernel-owner@vger.kernel.org To: Robert Jarzmik Cc: Jiri Slaby , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Sergey Yanovich , Heikki Krogerus , James Cameron , Russell King List-Id: linux-serial@vger.kernel.org On Thu, Oct 06, 2016 at 08:25:35AM +0200, Robert Jarzmik wrote: > Robert Jarzmik writes: > > > From: Sergey Yanovich > > > > pxa2xx-uart was a separate uart platform driver. It was declaring > > the same device names and numbers as 8250 driver. As a result, > > it was impossible to use 8250 driver on PXA SoCs. > > > > Upon closer examination pxa2xx-uart turned out to be a clone of > > 8250_core driver. > > > > Workaround for Erratum #19 according to Marvel(R) PXA270M Processor > > Specification Update (April 19, 2010) is dropped. 8250_core reads > > from FIFO immediately after checking DR bit in LSR. > > > > The patch leaves the original SERIAL_PXA driver around. The original > > driver is just marked DEPRECATED in Kconfig and C source. When > > the original driver is considered safe to remove, no changes > > to SERIAL_8250 will be necessary. > > > > Compiling SERIAL_8250_CONSOLE and SERIAL_PXA_CONSOLE even without > > SERIAL_8250_PXA breaks console for SERIAL_PXA. For this reasons, the new > > and the original drivers are made mutually exclusive. > > > > Signed-off-by: Sergei Ianovich > > CC: Heikki Krogerus > > CC: James Cameron > > CC: Greg Kroah-Hartman > > CC: Robert Jarzmik > > CC: Russell King > > Reviewed-by: Heikki Krogerus > > [rebased on v4.8] > > Tested-by: Robert Jarzmik > > Signed-off-by: Robert Jarzmik > > Greg, can you take that into you tty tree please ? Please wait until after the 4.9-rc1 merge window is over before worrying about new patches being applied to my trees... thanks, greg k-h