From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [patch] serial: stm32: fix a type issue Date: Wed, 12 Oct 2016 09:52:39 +0100 Message-ID: <20161012085239.GD1041@n2100.armlinux.org.uk> References: <20161012062103.GS12841@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20161012062103.GS12841@mwanda> Sender: kernel-janitors-owner@vger.kernel.org To: Dan Carpenter Cc: Greg Kroah-Hartman , Alexandre TORGUE , linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org, linux-serial@vger.kernel.org, Maxime Coquelin , Jiri Slaby List-Id: linux-serial@vger.kernel.org On Wed, Oct 12, 2016 at 09:21:03AM +0300, Dan Carpenter wrote: > We store UNDEF_REG in a u8. It causes a problem in functions like > stm32_tx_dma_complete() where we check "if (ofs->icr == UNDEF_REG)". > > Fixes: 3489187204eb ('serial: stm32: adding dma support') Correct form is: Fixes: 12-digit-hash ("summary line") -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.