From: Simon Horman <horms@verge.net.au>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Wolfram Sang <wsa@sang-engineering.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-serial@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH/RFC] serial: sh-sci: Fix deadlock caused by serial output request
Date: Mon, 7 Nov 2016 16:38:24 +0100 [thread overview]
Message-ID: <20161107153823.GA9233@verge.net.au> (raw)
In-Reply-To: <20161107152618.GB5140@katana>
On Mon, Nov 07, 2016 at 04:26:18PM +0100, Wolfram Sang wrote:
> On Mon, Nov 07, 2016 at 04:14:41PM +0100, Simon Horman wrote:
> > From: Takatoshi Akiyama <takatoshi.akiyama.kj@ps.hitachi-solutions.com>
> >
> > While spin is already locked, serial output request causes the deadlock,
> > because serial output process also tries to lock the spin.
> > This patch removes serial output with spin locked.
> >
> > Signed-off-by: Takatoshi Akiyama <takatoshi.akiyama.kj@ps.hitachi-solutions.com>
> > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > This is a patch from the Gen3 3.3.2 BSP.
> > Geert, please consider it for mainline.
> >
> > Two approaches are mixed here: simply removing log messages that would
> > cause a deadlock; and moving log messages to outside the lock. Some
> > consideration was given (by Simon) to a more consistent approach of
> > simply removing all log messages in question. However this was taken as
> > logging ouside of the lock seems consistent with other logging in
> > rx_timer_fn() and sci_dma_rx_complete().
>
> Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> Simon, could you use the 'wsa+renesas' email address in the future? That
> would make things a tad easier for me. Thanks!
Sure, I will try to do that.
prev parent reply other threads:[~2016-11-07 15:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 15:14 [PATCH/RFC] serial: sh-sci: Fix deadlock caused by serial output request Simon Horman
2016-11-07 15:20 ` Geert Uytterhoeven
2016-11-07 15:40 ` Simon Horman
2016-11-07 15:42 ` Geert Uytterhoeven
2016-11-07 15:44 ` Simon Horman
2016-11-07 15:26 ` Wolfram Sang
2016-11-07 15:38 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161107153823.GA9233@verge.net.au \
--to=horms@verge.net.au \
--cc=geert@linux-m68k.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=wsa@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).