* [PATCH] serial: 8250_pxa: hide early console setup when disabled
@ 2016-11-09 13:27 Arnd Bergmann
2016-11-09 20:16 ` Robert Jarzmik
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-11-09 13:27 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Arnd Bergmann, Jiri Slaby, Robert Jarzmik, linux-serial,
linux-kernel
The newly added pxa glue driver for 8250 supports console output, but
fails to build if the 8250 console is disabled:
drivers/tty/serial/8250/8250_pxa.o: In function `early_serial_pxa_setup':
8250_pxa.c:(.init.text+0x50): undefined reference to `early_serial8250_setup'
This adds an #ifdef like the other glue drivers have it.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/tty/serial/8250/8250_pxa.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/tty/serial/8250/8250_pxa.c b/drivers/tty/serial/8250/8250_pxa.c
index 31f27d95d8b4..4d68731af534 100644
--- a/drivers/tty/serial/8250/8250_pxa.c
+++ b/drivers/tty/serial/8250/8250_pxa.c
@@ -170,6 +170,7 @@ static struct platform_driver serial_pxa_driver = {
module_platform_driver(serial_pxa_driver);
+#ifdef CONFIG_SERIAL_8250_CONSOLE
static int __init early_serial_pxa_setup(struct earlycon_device *device,
const char *options)
{
@@ -182,6 +183,7 @@ static int __init early_serial_pxa_setup(struct earlycon_device *device,
return early_serial8250_setup(device, NULL);
}
OF_EARLYCON_DECLARE(early_pxa, "mrvl,pxa-uart", early_serial_pxa_setup);
+#endif
MODULE_AUTHOR("Sergei Ianovich");
MODULE_LICENSE("GPL");
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] serial: 8250_pxa: hide early console setup when disabled
2016-11-09 13:27 [PATCH] serial: 8250_pxa: hide early console setup when disabled Arnd Bergmann
@ 2016-11-09 20:16 ` Robert Jarzmik
0 siblings, 0 replies; 2+ messages in thread
From: Robert Jarzmik @ 2016-11-09 20:16 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Greg Kroah-Hartman, Jiri Slaby, linux-serial, linux-kernel
Arnd Bergmann <arnd@arndb.de> writes:
> The newly added pxa glue driver for 8250 supports console output, but
> fails to build if the 8250 console is disabled:
>
> drivers/tty/serial/8250/8250_pxa.o: In function `early_serial_pxa_setup':
> 8250_pxa.c:(.init.text+0x50): undefined reference to `early_serial8250_setup'
>
> This adds an #ifdef like the other glue drivers have it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-09 20:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-09 13:27 [PATCH] serial: 8250_pxa: hide early console setup when disabled Arnd Bergmann
2016-11-09 20:16 ` Robert Jarzmik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).