From: Greg KH <gregkh@linuxfoundation.org>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: jslaby@suse.com, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: 8250_dw: #ifdef out dw8250_acpi_match if ACPI isn't set
Date: Fri, 23 Dec 2016 19:09:23 +0100 [thread overview]
Message-ID: <20161223180923.GA26878@kroah.com> (raw)
In-Reply-To: <20161223123355.1370-1-jszhang@marvell.com>
On Fri, Dec 23, 2016 at 08:33:55PM +0800, Jisheng Zhang wrote:
> dw8250_acpi_match is used only when ACPI is enabled. Fix the following
> gcc warning when W=1 is set:
>
> drivers/tty/serial/8250/8250_dw.c:640:36: warning: 'dw8250_acpi_match'
> defined but not used [-Wunused-const-variable=]
Don't set W=1 then, this type of "fix" is foolish and is just going to
make code messier, sorry.
greg k-h
next prev parent reply other threads:[~2016-12-23 18:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 12:33 [PATCH] serial: 8250_dw: #ifdef out dw8250_acpi_match if ACPI isn't set Jisheng Zhang
2016-12-23 18:09 ` Greg KH [this message]
2016-12-26 5:28 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161223180923.GA26878@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=jszhang@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).