From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, Jiri Slaby <jslaby@suse.com>,
linux-arm-msm@vger.kernel.org, Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
linux-serial@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-soc@vger.kernel.org
Subject: Re: [PATCH] tty: serial: msm: Fix module autoload
Date: Tue, 3 Jan 2017 10:53:36 -0800 [thread overview]
Message-ID: <20170103185335.GK10531@minitux> (raw)
In-Reply-To: <1483369040-21442-1-git-send-email-javier@osg.samsung.com>
On Mon 02 Jan 06:57 PST 2017, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/tty/serial/msm_serial.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/tty/serial/msm_serial.ko | grep alias
> alias: of:N*T*Cqcom,msm-uartdmC*
> alias: of:N*T*Cqcom,msm-uartdm
> alias: of:N*T*Cqcom,msm-uartC*
> alias: of:N*T*Cqcom,msm-uart
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
>
> drivers/tty/serial/msm_serial.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c
> index 7312e7e01b7e..6788e7532dff 100644
> --- a/drivers/tty/serial/msm_serial.c
> +++ b/drivers/tty/serial/msm_serial.c
> @@ -1809,6 +1809,7 @@ static const struct of_device_id msm_match_table[] = {
> { .compatible = "qcom,msm-uartdm" },
> {}
> };
> +MODULE_DEVICE_TABLE(of, msm_match_table);
>
> static struct platform_driver msm_platform_driver = {
> .remove = msm_serial_remove,
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-01-03 18:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 14:57 [PATCH] tty: serial: msm: Fix module autoload Javier Martinez Canillas
2017-01-03 18:53 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170103185335.GK10531@minitux \
--to=bjorn.andersson@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=javier@osg.samsung.com \
--cc=jslaby@suse.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).