* [PATCH] tty: serial: msm: Fix module autoload
@ 2017-01-02 14:57 Javier Martinez Canillas
2017-01-03 18:53 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Javier Martinez Canillas @ 2017-01-02 14:57 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Jiri Slaby, linux-arm-msm, Andy Gross,
David Brown, linux-serial, Greg Kroah-Hartman, linux-soc
If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.
Export the module alias information using the MODULE_DEVICE_TABLE() macro.
Before this patch:
$ modinfo drivers/tty/serial/msm_serial.ko | grep alias
$
After this patch:
$ modinfo drivers/tty/serial/msm_serial.ko | grep alias
alias: of:N*T*Cqcom,msm-uartdmC*
alias: of:N*T*Cqcom,msm-uartdm
alias: of:N*T*Cqcom,msm-uartC*
alias: of:N*T*Cqcom,msm-uart
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/tty/serial/msm_serial.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c
index 7312e7e01b7e..6788e7532dff 100644
--- a/drivers/tty/serial/msm_serial.c
+++ b/drivers/tty/serial/msm_serial.c
@@ -1809,6 +1809,7 @@ static const struct of_device_id msm_match_table[] = {
{ .compatible = "qcom,msm-uartdm" },
{}
};
+MODULE_DEVICE_TABLE(of, msm_match_table);
static struct platform_driver msm_platform_driver = {
.remove = msm_serial_remove,
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tty: serial: msm: Fix module autoload
2017-01-02 14:57 [PATCH] tty: serial: msm: Fix module autoload Javier Martinez Canillas
@ 2017-01-03 18:53 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2017-01-03 18:53 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel, Jiri Slaby, linux-arm-msm, Andy Gross, David Brown,
linux-serial, Greg Kroah-Hartman, linux-soc
On Mon 02 Jan 06:57 PST 2017, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/tty/serial/msm_serial.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/tty/serial/msm_serial.ko | grep alias
> alias: of:N*T*Cqcom,msm-uartdmC*
> alias: of:N*T*Cqcom,msm-uartdm
> alias: of:N*T*Cqcom,msm-uartC*
> alias: of:N*T*Cqcom,msm-uart
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
>
> drivers/tty/serial/msm_serial.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c
> index 7312e7e01b7e..6788e7532dff 100644
> --- a/drivers/tty/serial/msm_serial.c
> +++ b/drivers/tty/serial/msm_serial.c
> @@ -1809,6 +1809,7 @@ static const struct of_device_id msm_match_table[] = {
> { .compatible = "qcom,msm-uartdm" },
> {}
> };
> +MODULE_DEVICE_TABLE(of, msm_match_table);
>
> static struct platform_driver msm_platform_driver = {
> .remove = msm_serial_remove,
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-03 18:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-02 14:57 [PATCH] tty: serial: msm: Fix module autoload Javier Martinez Canillas
2017-01-03 18:53 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).