From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jason Uy <jason.uy@broadcom.com>
Cc: Jiri Slaby <jslaby@suse.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Noam Camus <noamc@ezchip.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Wang Hongcheng <annie.wang@amd.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH v1 1/1] serial: 8250_dw: Allow hardware flow control to be used
Date: Wed, 11 Jan 2017 09:00:55 +0100 [thread overview]
Message-ID: <20170111080055.GA8548@kroah.com> (raw)
In-Reply-To: <1481063643-11951-2-git-send-email-jason.uy@broadcom.com>
On Tue, Dec 06, 2016 at 02:34:03PM -0800, Jason Uy wrote:
> In the most common use case, the Synopsys DW UART driver does not
> set the set_termios callback function. This prevents UPSTAT_AUTOCTS
> from being set when the UART flag CRTSCTS is set. As a result, the
> driver will use software flow control as opposed to hardware flow
> control.
>
> To fix the problem, the set_termios callback function is set to the
> DW specific function. The logic to set UPSTAT_AUTOCTS is moved so
> that any clock error will not affect setting the hardware flow
> control.
>
> Reviewed-by: Scott Branden <scott.branden@broadcom.com>
> Reviewed-by: Ray Jui <ray.jui@broadcom.com>
> Signed-off-by: Jason Uy <jason.uy@broadcom.com>
> ---
> drivers/tty/serial/8250/8250_dw.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
This patch doesn't apply at all to the latest kernel tree. Can you
please refresh it and resend?
thanks,
greg k-h
prev parent reply other threads:[~2017-01-11 8:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 22:34 [PATCH v1 0/1] serial: 8250_dw: Allow hardware flow control to be used Jason Uy
2016-12-06 22:34 ` [PATCH v1 1/1] " Jason Uy
2016-12-07 11:09 ` Andy Shevchenko
2017-01-11 8:00 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170111080055.GA8548@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=annie.wang@amd.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jason.uy@broadcom.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=noamc@ezchip.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).