From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jisheng Zhang Subject: Re: [PATCH] serial: 8250: 8250_core: Use dev_name() during request_irq() Date: Wed, 15 Mar 2017 14:10:01 +0800 Message-ID: <20170315141001.62c4fc67@xhacker> References: <20170308121943.29340-1-vigneshr@ti.com> <2a0cf043-6e3f-6807-0794-d9d6f46b77f5@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Andy Shevchenko Cc: Vignesh R , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , "linux-serial@vger.kernel.org" , Jiri Slaby , linux-arm Mailing List List-Id: linux-serial@vger.kernel.org On Tue, 14 Mar 2017 17:59:01 +0200 Andy Shevchenko wrote: > On Tue, Mar 14, 2017 at 3:44 PM, Vignesh R wrote: > > On Monday 13 March 2017 01:35 AM, Andy Shevchenko wrote: > >> On Wed, Mar 8, 2017 at 2:19 PM, Vignesh R wrote: > >>> Passing "serial" as name during request_irq() results in all serial port > >>> irqs have same name. This does not help much to easily identify which > >>> irq belongs to which serial port instance. Therefore pass dev_name() > >>> during request_irq() so that better identifiable name is listed for > >>> serial ports in cat /proc/interrupts output. > >>> > >>> Output of cat /proc/interrupts > >>> Before this patch: > >>> 26: 689 0 GICv2 309 Edge serial > >>> After this patch: > >>> 26: 696 0 GICv2 309 Edge 2530c00.serial > > > But, this change is making interrupt name more descriptive > > It doesn't in PCI case, it makes it worse. indeed, in PCI case, I see 4: ... 00:03.3 what about "dev_driver_string(up->port.dev)[dev_name(up->port.dev)]" as we did for ahci case? Thanks