From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Aleksey Makarov <aleksey.makarov@linaro.org>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Sudeep Holla <sudeep.holla@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Peter Hurley <peter@hurleysoftware.com>,
Jiri Slaby <jslaby@suse.com>, Robin Murphy <robin.murphy@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
"Nair, Jayachandran" <Jayachandran.Nair@cavium.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Petr Mladek <pmladek@suse.com>
Subject: Re: [PATCH v7 3/3] printk: fix double printing with earlycon
Date: Mon, 20 Mar 2017 15:16:58 +0900 [thread overview]
Message-ID: <20170320061206.GA594@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <20170317134352.5725-1-aleksey.makarov@linaro.org>
Hello,
On (03/17/17 16:43), Aleksey Makarov wrote:
[..]
> +static void ensure_preferred_is_last(int i)
> +{
> + int last;
> +
> + for (last = MAX_CMDLINECONSOLES - 1;
> + last >= 0 && !console_cmdline[last].name[0];
> + last--)
> + ;
> +
> + BUG_ON(last < 0);
let's not panic().
a nitpick, console swap can be done as
if (i != last)
swap(console_cmdline[i], console_cmdline[last]);
preferred_console = last;
-ss
next prev parent reply other threads:[~2017-03-20 6:16 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 10:28 [PATCH v5 0/3] printk: fix double printing with earlycon Aleksey Makarov
2017-03-15 10:28 ` [PATCH v5 1/3] printk: fix name/type/scope of preferred_console var Aleksey Makarov
2017-03-15 10:28 ` [PATCH v5 2/3] printk: rename selected_console -> preferred_console Aleksey Makarov
2017-03-15 10:28 ` [PATCH v5 3/3] printk: fix double printing with earlycon Aleksey Makarov
2017-03-15 16:58 ` Petr Mladek
2017-03-16 7:30 ` Sergey Senozhatsky
2017-03-16 10:36 ` Aleksey Makarov
2017-03-16 13:54 ` Petr Mladek
2017-03-17 10:32 ` Aleksey Makarov
2017-03-17 11:43 ` [PATCH v6 " Aleksey Makarov
2017-03-17 13:34 ` Aleksey Makarov
2017-03-17 13:43 ` [PATCH v7 " Aleksey Makarov
2017-03-20 6:16 ` Sergey Senozhatsky [this message]
2017-03-20 10:03 ` [PATCH v8 " Aleksey Makarov
2017-03-27 14:14 ` Petr Mladek
2017-03-27 16:28 ` Aleksey Makarov
2017-03-28 2:04 ` Sergey Senozhatsky
2017-03-28 12:56 ` Petr Mladek
2017-03-30 5:55 ` Sergey Senozhatsky
2017-04-04 11:12 ` Petr Mladek
2017-04-05 18:26 ` Aleksey Makarov
2017-04-05 20:20 ` [PATCH v9 " Aleksey Makarov
2017-04-05 21:57 ` Andy Shevchenko
2017-04-06 4:44 ` Aleksey Makarov
2017-04-10 14:22 ` Petr Mladek
2017-04-10 18:00 ` Aleksey Makarov
2017-04-11 1:54 ` Sergey Senozhatsky
2017-04-11 7:43 ` Petr Mladek
2017-04-12 6:24 ` Aleksey Makarov
2017-05-09 8:29 ` Sabrina Dubroca
2017-05-11 8:24 ` Sergey Senozhatsky
2017-05-11 8:41 ` Sergey Senozhatsky
2017-05-11 11:32 ` Sergey Senozhatsky
2017-05-11 21:17 ` Aleksey Makarov
2017-05-12 1:11 ` Sergey Senozhatsky
2017-05-11 21:13 ` Aleksey Makarov
2017-05-12 12:57 ` Petr Mladek
2017-05-12 13:46 ` Petr Mladek
2017-05-14 21:01 ` Aleksey Makarov
2017-05-13 11:48 ` Sergey Senozhatsky
2017-05-14 20:37 ` Aleksey Makarov
2017-05-18 15:49 ` Petr Mladek
2017-05-26 9:37 ` Aleksey Makarov
2017-06-01 12:03 ` Petr Mladek
2017-06-06 14:31 ` Petr Mladek
2017-06-06 16:03 ` Petr Mladek
2017-06-07 9:13 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320061206.GA594@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky.work@gmail.com \
--cc=Jayachandran.Nair@cavium.com \
--cc=aleksey.makarov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=pmladek@suse.com \
--cc=robin.murphy@arm.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).