From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Inki Dae <inki.dae@samsung.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/2] serial: samsung: Use right device for DMA-mapping calls
Date: Thu, 23 Mar 2017 21:51:55 +0200 [thread overview]
Message-ID: <20170323195155.u3bfvuo6rxncsgzr@kozik-lap> (raw)
In-Reply-To: <1490270519-4046-1-git-send-email-m.szyprowski@samsung.com>
On Thu, Mar 23, 2017 at 01:01:52PM +0100, Marek Szyprowski wrote:
> Driver should provide its own struct device for all DMA-mapping calls instead
> of extracting device pointer from DMA engine channel.
For the purpose of cc-stable it might be useful to answer here what
visible error is fixed (or why driver should not use DMA's device) but
on the other hand this is actually obvious... Anyway:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
> Reported-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> Fixes: 62c37eedb74c8 ("serial: samsung: add dma reqest/release functions")
> CC: stable@vger.kernel.org # v4.0+
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
> v2:
> - fixed commit id in 'fixes' tag, added 'reviewed-by' tag
> ---
> drivers/tty/serial/samsung.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
next prev parent reply other threads:[~2017-03-23 19:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170323120208eucas1p28df58f312314337e9750d23930de733b@eucas1p2.samsung.com>
2017-03-23 12:01 ` [PATCH v2 1/2] serial: samsung: Use right device for DMA-mapping calls Marek Szyprowski
2017-03-23 12:01 ` [PATCH v2 2/2] serial: samsung: Add missing checks for dma_map_single failure Marek Szyprowski
2017-03-23 20:04 ` Krzysztof Kozlowski
2017-03-23 19:51 ` Krzysztof Kozlowski [this message]
2017-03-31 13:35 ` [PATCH v2 1/2] serial: samsung: Use right device for DMA-mapping calls Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170323195155.u3bfvuo6rxncsgzr@kozik-lap \
--to=krzk@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=inki.dae@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=stable@vger.kernel.org \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox