From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
Petr Mladek <pmladek@suse.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Ming Lei <ming.lei@canonical.com>,
Aleksey Makarov <aleksey.makarov@linaro.org>,
linux-serial@vger.kernel.org, Joe Perches <joe@perches.com>,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCHv2] braille-console: Fix value returned by _braille_console_setup
Date: Tue, 28 Mar 2017 00:43:41 +0900 [thread overview]
Message-ID: <20170327154341.GA996@tigerII.localdomain> (raw)
In-Reply-To: <20170326204736.65jjbfrfvammgxqy@var.youpi.perso.aquilenet.fr>
On (03/26/17 22:47), Samuel Thibault wrote:
> commit bbeddf52adc1 ("printk: move braille console support into
> separate braille.[ch] files") introduced _braille_console_setup()
> to outline the braille initialization code. There was however some
> confusion over the value it was supposed to return. commit 2cfe6c4ac7ee
> ("printk: Fix return of braille_register_console()") tried to fix it
> but failed to.
>
> This fixes and documents the returned value according to the use
> in printk.c: non-zero return means a parsing error, and thus this
> console configuration should be ignored.
I just found this patch in my gmail "spam" folder.
sorry.
the patch looks OK to me.
btw, is there any reason why _braille_console_setup() and
_braille_register_console()/_braille_unregister_console()
names start with a dash? do we also want to "clean this up"?
well since we are at it.
-ss
prev parent reply other threads:[~2017-03-27 15:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-26 20:47 [PATCHv2] braille-console: Fix value returned by _braille_console_setup Samuel Thibault
2017-03-27 15:43 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327154341.GA996@tigerII.localdomain \
--to=sergey.senozhatsky@gmail.com \
--cc=aleksey.makarov@linaro.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox