From: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
To: linux-serial@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
Jiri Slaby <jslaby@suse.com>
Subject: [PATCH v2 0/2] Move uart_register_driver call to device probe for pl010 and sh-sci
Date: Thu, 20 Apr 2017 14:12:59 +0200 [thread overview]
Message-ID: <20170420121301.382-1-sjoerd.simons@collabora.co.uk> (raw)
When testing on a Renesas board with the PL010 serial driver enabled
serial output broke. Turns out the minor device numbers for both
drivers happen to overlap, causing whichever driver happened to be the
second one to register to fail.
The attached patches move the uart_register_driver call to probe time
for both drivers avoiding the issue.
Changes in v2:
- Add locking to prevent issues when two probes run in parallel
Sjoerd Simons (2):
serial: pl010: Move uart_register_driver call to device probe
serial: sh-sci: Move uart_register_driver call to device probe
drivers/tty/serial/amba-pl010.c | 31 +++++++++++++++++++++----------
drivers/tty/serial/sh-sci.c | 26 +++++++++++++++-----------
2 files changed, 36 insertions(+), 21 deletions(-)
--
2.11.0
next reply other threads:[~2017-04-20 12:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 12:12 Sjoerd Simons [this message]
2017-04-20 12:13 ` [PATCH v2 1/2] serial: pl010: Move uart_register_driver call to device probe Sjoerd Simons
2017-04-20 12:13 ` [PATCH v2 2/2] serial: sh-sci: " Sjoerd Simons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170420121301.382-1-sjoerd.simons@collabora.co.uk \
--to=sjoerd.simons@collabora.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox