From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dong Aisheng Subject: Re: [V2, 2/6] tty: serial: lpuart: add little endian 32 bit register support Date: Wed, 17 May 2017 11:31:40 +0800 Message-ID: <20170517033139.GB9913@b29396-OptiPlex-7040> References: <1494834539-17523-3-git-send-email-aisheng.dong@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Nikita Yushchenko Cc: Dong Aisheng , linux-serial@vger.kernel.org, fugang.duan@nxp.com, gregkh@linuxfoundation.org, yangbo.lu@nxp.com, linux-kernel@vger.kernel.org, stefan@agner.ch, Mingkai.Hu@nxp.com, jslaby@suse.com, linux-arm-kernel@lists.infradead.org List-Id: linux-serial@vger.kernel.org On Tue, May 16, 2017 at 02:08:12PM +0300, Nikita Yushchenko wrote: > > @@ -2000,6 +2007,7 @@ static int lpuart_probe(struct platform_device *pdev) > > } > > sport->port.line = ret; > > sport->lpuart32 = sdata->is_32; > > + lpuart_is_be = sdata->is_be; > > Setting a global variable in per-device routine is quite bad design. > There is a reason for that we don't want to change the exist lpuart32_read[write] API which is widely used in driver. Making a global lpuart_is_be is the simplest way to do it. Any strong blocking reason? Regards Dong Aisheng