linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>, Tony Luck <tony.luck@intel.com>,
	Fenghua Yu <fenghua.yu@intel.com>,
	Samuel Ortiz <samuel@sortiz.org>,
	"David S. Miller" <davem@davemloft.net>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-serial@vger.kernel.org, Johan Hovold <johan@kernel.org>
Subject: [PATCH 0/9] tty: drop broken alt-speed handling
Date: Tue,  6 Jun 2017 12:54:32 +0200	[thread overview]
Message-ID: <20170606105441.689-1-johan@kernel.org> (raw)

Setting an alt-speed using TIOCSSERIAL and SPD flags has been deprecated
since v2.1.69 and has been broken for all tty drivers but serial-core
since v3.10 and commit 6865ff222cca ("TTY: do not warn about setting
speed via SPD_*") without anyone noticing (for four years).

Instead of reverting the offending commit, lets get rid of this legacy
code while adding back a warning about the SPD flags being deprecated to
the drivers that once implemented it. Note that drivers implementing
SPD_CUST will continue to support using a custom divisor.

Also note that serial-core did not rely on the TTY layer for SPD
handling and continues to support it while warning about deprecation
(since 2003 at least).

Greg, I suggest you take it all trough the TTY tree even if merging
through multiple trees and applying the final patch once everything is
upstream would be an option. Also the irda clean up does not depend on
the rest of series as the code implementing SPD handling was ifdefed
out.

Johan


Johan Hovold (9):
  serial: rate limit custom-speed deprecation notice
  USB: serial: ftdi_sio: simplify TIOCSSERIAL flag logic
  USB: serial: ftdi_sio: remove broken alt-speed handling
  tty: simserial: drop unused alt_speed handling
  tty: amiserial: drop broken alt-speed support
  tty: cyclades: drop broken alt-speed support
  tty: rocket: drop broken alt-speed support
  tty: ircomm: remove dead and broken ioctl code
  tty: drop unused alt_speed from tty_struct

 arch/ia64/hp/sim/simserial.c       |  13 -----
 drivers/tty/amiserial.c            |  23 ++------
 drivers/tty/cyclades.c             |  21 ++++----
 drivers/tty/rocket.c               |  27 +++-------
 drivers/tty/serial/serial_core.c   |   5 +-
 drivers/usb/serial/ftdi_sio.c      |  67 +++++------------------
 include/linux/tty.h                |   1 -
 net/irda/ircomm/ircomm_tty_ioctl.c | 107 +------------------------------------
 8 files changed, 34 insertions(+), 230 deletions(-)

-- 
2.13.0

             reply	other threads:[~2017-06-06 10:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-06 10:54 Johan Hovold [this message]
2017-06-06 10:54 ` [PATCH 1/9] serial: rate limit custom-speed deprecation notice Johan Hovold
2017-06-06 10:54 ` [PATCH 2/9] USB: serial: ftdi_sio: simplify TIOCSSERIAL flag logic Johan Hovold
2017-06-06 10:54 ` [PATCH 3/9] USB: serial: ftdi_sio: remove broken alt-speed handling Johan Hovold
2017-06-06 10:54 ` [PATCH 4/9] tty: simserial: drop unused alt_speed handling Johan Hovold
2017-06-06 10:54 ` [PATCH 5/9] tty: amiserial: drop broken alt-speed support Johan Hovold
2017-06-06 10:54 ` [PATCH 6/9] tty: cyclades: " Johan Hovold
2017-06-06 10:54 ` [PATCH 7/9] tty: rocket: " Johan Hovold
2017-06-06 10:54 ` [PATCH 8/9] tty: ircomm: remove dead and broken ioctl code Johan Hovold
2017-06-06 11:27   ` Alan Cox
2017-06-13  9:48     ` Greg Kroah-Hartman
2017-06-13  9:57       ` Johan Hovold
2017-06-13 10:00         ` Johan Hovold
2017-06-13 10:01         ` Greg Kroah-Hartman
2017-06-06 10:54 ` [PATCH 9/9] tty: drop unused alt_speed from tty_struct Johan Hovold
2017-06-06 11:29 ` [PATCH 0/9] tty: drop broken alt-speed handling Alan Cox
2017-06-07  9:53 ` Andy Shevchenko
2017-06-13  9:55 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170606105441.689-1-johan@kernel.org \
    --to=johan@kernel.org \
    --cc=davem@davemloft.net \
    --cc=fenghua.yu@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=samuel@sortiz.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).