From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Richard Genoud <richard.genoud@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] tty/serial: atmel: make the driver DT only
Date: Tue, 13 Jun 2017 21:56:08 +0200 [thread overview]
Message-ID: <20170613195608.3tfckys7w42sgmiy@piout.net> (raw)
In-Reply-To: <CAHp75VdQu=mm3hPb32+3osbx+wugH4iTFqAnz8-2GDmsYV8ViA@mail.gmail.com>
On 13/06/2017 at 17:50:25 +0300, Andy Shevchenko wrote:
> On Tue, Jun 13, 2017 at 4:40 PM, Alexandre Belloni
> <alexandre.belloni@free-electrons.com> wrote:
> > Now that AVR32 is gone, platform_data are not used to initialize the driver
> > anymore, remove that path from the driver. Also remove the now unused
> > struct atmel_uart_data.
>
> Nitpicks, not insisting on them at all, just a side comment.
>
> > + struct serial_rs485 *rs485conf = &port->rs485;
> > + u32 rs485_delay[2];
>
> + empty line?
>
Okay
> > + /* rs485 properties */
>
> > + if (of_property_read_u32_array(np, "rs485-rts-delay",
> > + rs485_delay, 2) == 0) {
>
> Now it can be one line I suppose (taking into account ...() == 0 ->
> !...() change)
>
No, it still doesn't fit, I'll leave it as-is
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2017-06-13 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 13:40 [PATCH 1/2] tty/serial: atmel: remove atmel_default_console_device handling Alexandre Belloni
2017-06-13 13:40 ` [PATCH 2/2] tty/serial: atmel: make the driver DT only Alexandre Belloni
2017-06-13 14:50 ` Andy Shevchenko
2017-06-13 19:56 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170613195608.3tfckys7w42sgmiy@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=richard.genoud@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox