From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Jiri Slaby <jslaby@suse.com>, Arnd Bergmann <arnd@arndb.de>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
ldv-project@linuxtesting.org
Subject: Re: [PATCH] serial: 8250: fix error handling in of_platform_serial_probe()
Date: Tue, 18 Jul 2017 09:27:32 +0200 [thread overview]
Message-ID: <20170718072732.GA15573@kroah.com> (raw)
In-Reply-To: <1498862969-4919-1-git-send-email-khoroshilov@ispras.ru>
On Sat, Jul 01, 2017 at 01:49:29AM +0300, Alexey Khoroshilov wrote:
> clk_disable_unprepare(info->clk) is missed in of_platform_serial_probe(),
> while irq_dispose_mapping(port->irq) is missed in of_platform_serial_setup().
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> ---
> drivers/tty/serial/8250/8250_of.c | 20 +++++++++++++-------
> 1 file changed, 13 insertions(+), 7 deletions(-)
I've had to drop this from my tree due to the obvious build warning it
adds to the system. Always test-build your patches before sending them
out, it makes maintainers grumpy when you do not do that :(
greg k-h
next prev parent reply other threads:[~2017-07-18 7:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 22:49 [PATCH] serial: 8250: fix error handling in of_platform_serial_probe() Alexey Khoroshilov
2017-07-18 7:27 ` Greg Kroah-Hartman [this message]
2017-07-18 7:33 ` Alexey Khoroshilov
2017-07-18 11:32 ` [PATCH v2] " Alexey Khoroshilov
2017-07-18 15:06 ` Andy Shevchenko
2017-07-18 15:45 ` Johan Hovold
2017-07-18 15:55 ` Andy Shevchenko
2017-07-19 8:32 ` [PATCH v3] " Alexey Khoroshilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170718072732.GA15573@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=jslaby@suse.com \
--cc=khoroshilov@ispras.ru \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).