From: Johannes Thumshirn <jthumshirn@suse.de>
To: Michael Moese <michael.moese@men.de>
Cc: gregkh@linuxfoundation.org, jslaby@suse.com,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
johannes.thumshirn@suse.de
Subject: Re: [PATCH v2 2/2] Introduce 8250_men_mcb
Date: Fri, 11 Aug 2017 15:13:21 +0200 [thread overview]
Message-ID: <20170811131321.GA11543@linux-x5ow.site> (raw)
In-Reply-To: <20170802075853.18911-2-michael.moese@men.de>
On Wed, Aug 02, 2017 at 09:58:53AM +0200, Michael Moese wrote:
> This patch introduces the 8250_men_mcb driver for the MEN 16Z125
> IP-Core. This is a 16550-type UART with a 60 byte FIFO.
> Due to strange old hardware, every board using this IP core requires
> different values for uartclk. A reasonable default is included in
> addition to the support of three boards. Additional values for other
> boards will be added later.
>
> This v2 has some whitespace fixes, I screwed this up yesterday.
Nit: this should go below the '---' marker.
Apart from that,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
prev parent reply other threads:[~2017-08-11 13:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-02 7:58 [PATCH v2 1/2] mcb: introduce mcb_get_resource() Michael Moese
2017-08-02 7:58 ` [PATCH v2 2/2] Introduce 8250_men_mcb Michael Moese
2017-08-11 13:13 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170811131321.GA11543@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=johannes.thumshirn@suse.de \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=michael.moese@men.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).