From: Romain Izard <romain.izard.pro@gmail.com>
To: Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Wenyou Yang <wenyou.yang@atmel.com>,
Josh Wu <rainyfeeling@outlook.com>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
Thierry Reding <thierry.reding@gmail.com>,
Richard Genoud <richard.genoud@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mtd@lists.infradead.org, linux-pwm@vger.kernel.org,
linux-serial@vger.kernel.org, linux-usb@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Romain Izard <romain.izard.pro@gmail.com>
Subject: [PATCH v2 5/9] mtd: nand: atmel: Report PMECC failures as errors
Date: Fri, 15 Sep 2017 16:04:07 +0200 [thread overview]
Message-ID: <20170915140411.31716-6-romain.izard.pro@gmail.com> (raw)
In-Reply-To: <20170915140411.31716-1-romain.izard.pro@gmail.com>
It is not normal for the PMECC to fail when trying to fix ECC errors.
Report these cases as errors.
Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
---
drivers/mtd/nand/atmel/pmecc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/atmel/pmecc.c b/drivers/mtd/nand/atmel/pmecc.c
index 8d1208f38025..2a23f1ff945f 100644
--- a/drivers/mtd/nand/atmel/pmecc.c
+++ b/drivers/mtd/nand/atmel/pmecc.c
@@ -687,6 +687,8 @@ static int atmel_pmecc_err_location(struct atmel_pmecc_user *user)
* Number of roots does not match the degree of smu
* unable to correct error.
*/
+ dev_err(pmecc->dev,
+ "PMECC: Impossible to calculate error location.\n");
return -EBADMSG;
}
@@ -729,7 +731,7 @@ int atmel_pmecc_correct_sector(struct atmel_pmecc_user *user, int sector,
ptr = ecc + byte - sectorsize;
area = "ECC";
} else {
- dev_dbg(pmecc->dev,
+ dev_err(pmecc->dev,
"Invalid errpos value (%d, max is %d)\n",
errpos, (sectorsize + eccbytes) * 8);
return -EINVAL;
--
2.11.0
next prev parent reply other threads:[~2017-09-15 14:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 14:04 [PATCH v2 0/9] Various patches for SAMA5D2 backup mode Romain Izard
2017-09-15 14:04 ` [PATCH v2 1/9] clk: at91: pmc: Wait for clocks when resuming Romain Izard
2017-09-22 12:05 ` Ludovic Desroches
2017-09-22 12:13 ` Nicolas Ferre
2017-09-15 14:04 ` [PATCH v2 2/9] clk: at91: pmc: Save SCSR during suspend Romain Izard
2017-09-15 14:04 ` [PATCH v2 3/9] clk: at91: pmc: Support backup for programmable clocks Romain Izard
2017-09-22 10:31 ` Nicolas Ferre
2017-09-25 8:25 ` Romain Izard
2017-09-15 14:04 ` [PATCH v2 4/9] mtd: nand: atmel: Avoid ECC errors when leaving backup mode Romain Izard
2017-09-18 9:50 ` Boris Brezillon
2017-09-15 14:04 ` Romain Izard [this message]
2017-09-18 10:00 ` [PATCH v2 5/9] mtd: nand: atmel: Report PMECC failures as errors Boris Brezillon
2017-09-21 9:22 ` Romain Izard
2017-09-15 14:04 ` [PATCH v2 6/9] ehci-atmel: Power down during suspend is normal Romain Izard
2017-09-22 12:40 ` Nicolas Ferre
2017-09-15 14:04 ` [PATCH v2 7/9] pwm: atmel-tcb: Support backup mode Romain Izard
2017-09-22 12:42 ` Nicolas Ferre
2017-09-15 14:04 ` [PATCH v2 8/9] atmel_flexcom: " Romain Izard
2017-09-19 9:29 ` Nicolas Ferre
2017-09-19 15:25 ` Lee Jones
2017-09-20 8:30 ` Romain Izard
2017-09-20 9:18 ` Alexandre Belloni
2017-09-15 14:04 ` [PATCH v2 9/9] tty/serial: atmel: Prevent a warning on suspend Romain Izard
2017-09-19 10:19 ` Nicolas Ferre
2017-09-20 14:35 ` Richard Genoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170915140411.31716-6-romain.izard.pro@gmail.com \
--to=romain.izard.pro@gmail.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=marek.vasut@gmail.com \
--cc=mturquette@baylibre.com \
--cc=nicolas.ferre@microchip.com \
--cc=rainyfeeling@outlook.com \
--cc=richard.genoud@gmail.com \
--cc=sboyd@codeaurora.org \
--cc=stern@rowland.harvard.edu \
--cc=thierry.reding@gmail.com \
--cc=wenyou.yang@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).