From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martyn Welch Subject: Re: [PATCH] Use RX_BUF_SIZE to set size of RX buffer Date: Thu, 28 Sep 2017 11:04:51 +0100 Message-ID: <20170928100451.GL6739@hermes.home> References: <1506592335-12623-1-git-send-email-martyn.welch@collabora.co.uk> <20170928100019.ynpbdctn65vxf7kq@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20170928100019.ynpbdctn65vxf7kq@pengutronix.de> Sender: linux-kernel-owner@vger.kernel.org To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-serial@vger.kernel.org On Thu, Sep 28, 2017 at 12:00:19PM +0200, Uwe Kleine-König wrote: > On Thu, Sep 28, 2017 at 10:52:15AM +0100, Martyn Welch wrote: > > The imx serial driver uses PAGE_SIZE when allocating rx_buf, but then > > uses RX_BUF_SIZE (which is currently defined as PAGE_SIZE) to describe > > the length of the buffer when initialising the scatter gather list. > > > > In order to ensure that this stays consistent, use RX_BUF_SIZE in both > > locations. > > Missing SoB Line Doh! v2 on way... > > > --- > > drivers/tty/serial/imx.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c > > index fe368a4..bc2f2a2f 100644 > > --- a/drivers/tty/serial/imx.c > > +++ b/drivers/tty/serial/imx.c > > @@ -1165,7 +1165,7 @@ static int imx_uart_dma_init(struct imx_port *sport) > > goto err; > > } > > > > - sport->rx_buf = kzalloc(PAGE_SIZE, GFP_KERNEL); > > + sport->rx_buf = kzalloc(RX_BUF_SIZE, GFP_KERNEL); > > if (!sport->rx_buf) { > > ret = -ENOMEM; > > goto err; > Acked-by: Uwe Kleine-König > > > -- > Pengutronix e.K. | Uwe Kleine-König | > Industrial Linux Solutions | http://www.pengutronix.de/ |