From: Troy Kisky <troy.kisky@boundarydevices.com>
To: gregkh@linuxfoundation.org, nandor.han@ge.com
Cc: Troy Kisky <troy.kisky@boundarydevices.com>,
linux-serial@vger.kernel.org, u.kleine-koenig@pengutronix.de,
fabio.estevam@nxp.com, linux-arm-kernel@lists.infradead.org,
l.stach@pengutronix.de
Subject: [PATCH v2 1/3] tty: serial: imx: disable ageing timer interrupt if dma in use
Date: Fri, 20 Oct 2017 14:20:19 -0700 [thread overview]
Message-ID: <20171020212021.13065-1-troy.kisky@boundarydevices.com> (raw)
Since commit 4dec2f119e86 ("imx-serial: RX DMA startup latency")
the interrupt routine no longer will start rx dma.
So, we no longer need to enable this interrupt to start dma.
Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
---
v2: split into a series of 2 patches
---
drivers/tty/serial/imx.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index dfeff3951f93..bf47b15df2e8 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -1207,10 +1207,6 @@ static void imx_enable_dma(struct imx_port *sport)
temp |= UCR1_RDMAEN | UCR1_TDMAEN | UCR1_ATDMAEN;
writel(temp, sport->port.membase + UCR1);
- temp = readl(sport->port.membase + UCR2);
- temp |= UCR2_ATEN;
- writel(temp, sport->port.membase + UCR2);
-
imx_setup_ufcr(sport, TXTL_DMA, RXTL_DMA);
sport->dma_is_enabled = 1;
--
2.11.0
next reply other threads:[~2017-10-20 21:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 21:20 Troy Kisky [this message]
2017-10-20 21:20 ` [PATCH v2 2/3] tty: serial: imx: remove dead code imx_dma_rxint Troy Kisky
2017-10-20 21:20 ` [PATCH v2 3/3] tty: serial: imx: remove imx_disable_rx_int Troy Kisky
2017-10-20 21:25 ` Troy Kisky
2017-10-22 18:49 ` Uwe Kleine-König
2017-10-23 8:26 ` Juergen Borleis
2017-11-04 11:39 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171020212021.13065-1-troy.kisky@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=fabio.estevam@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=nandor.han@ge.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).