From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Borleis Subject: Re: [PATCH v2 3/3] tty: serial: imx: remove imx_disable_rx_int Date: Mon, 23 Oct 2017 10:26:31 +0200 Message-ID: <201710231026.32595.jbe@pengutronix.de> References: <20171020212021.13065-1-troy.kisky@boundarydevices.com> <15ff545c-5aaf-4f03-3672-2c1702f78316@boundarydevices.com> <20171022184956.exmjlpcbzkvlp7xg@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20171022184956.exmjlpcbzkvlp7xg@pengutronix.de> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Uwe =?iso-8859-1?q?Kleine-K=F6nig?= Cc: gregkh@linuxfoundation.org, Troy Kisky , linux-serial@vger.kernel.org, nandor.han@ge.com, fabio.estevam@nxp.com, linux-arm-kernel@lists.infradead.org, l.stach@pengutronix.de List-Id: linux-serial@vger.kernel.org Hi, On Sunday 22 October 2017 20:49:56 Uwe Kleine-K=F6nig wrote: > On Fri, Oct 20, 2017 at 02:25:11PM -0700, Troy Kisky wrote: > > On 10/20/2017 2:20 PM, Troy Kisky wrote: > > > Since imx_disable_rx_int is only called by imx_startup, > > > let's integrate it into that function. > > > > > > Signed-off-by: Troy Kisky > > > --- > > > v2: new patch > > > --- > > > drivers/tty/serial/imx.c | 39 > > > ++++++++++----------------------------- 1 file changed, 10 > > > insertions(+), 29 deletions(-) > > > > While testing this series, I noticed that sending a break on the serial > > port caused > > > > imx-uart 2020000.serial: DMA transaction error. > > > > Is that normal ? > > I remember that J=FCrgen (added to To explictly) hit this or a similar > problem before, maybe he can commen? Yes, it hit me on i.MX53 after DMA was enabled by default. The driver = currently doesn't handle the "break" event when DMA is active. In this case = the DMA callback returns with an error (that's the message you see, but = it's not an error in this case...), the driver clears the flags and drops = the (break) event itself. jb -- = Pengutronix e.K. =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=A0 =A0= | Juergen Borleis =A0 =A0 =A0 =A0 =A0 =A0 | Industrial Linux Solutions =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0=A0 =A0| http://w= ww.pengutronix.de/ =A0|