From: Sebastian Reichel <sre@kernel.org>
To: Johan Hovold <johan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] tty: fix tty_ldisc_receive_buf() documentation
Date: Mon, 6 Nov 2017 14:39:44 +0100 [thread overview]
Message-ID: <20171106133944.2vkbbpl2tokhsabq@earth> (raw)
In-Reply-To: <20171103141805.20292-1-johan@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1130 bytes --]
Hi,
On Fri, Nov 03, 2017 at 03:18:05PM +0100, Johan Hovold wrote:
> The tty_ldisc_receive_buf() helper returns the number of bytes
> processed so drop the bogus "not" from the kernel doc comment.
>
> Fixes: 8d082cd300ab ("tty: Unify receive_buf() code paths")
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
-- Sebastian
> drivers/tty/tty_buffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c
> index f8eba1c5412f..677fa99b7747 100644
> --- a/drivers/tty/tty_buffer.c
> +++ b/drivers/tty/tty_buffer.c
> @@ -446,7 +446,7 @@ EXPORT_SYMBOL_GPL(tty_prepare_flip_string);
> * Callers other than flush_to_ldisc() need to exclude the kworker
> * from concurrent use of the line discipline, see paste_selection().
> *
> - * Returns the number of bytes not processed
> + * Returns the number of bytes processed
> */
> int tty_ldisc_receive_buf(struct tty_ldisc *ld, const unsigned char *p,
> char *f, int count)
> --
> 2.15.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-11-06 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 14:18 [PATCH] tty: fix tty_ldisc_receive_buf() documentation Johan Hovold
2017-11-06 13:39 ` Sebastian Reichel [this message]
2017-11-06 13:57 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171106133944.2vkbbpl2tokhsabq@earth \
--to=sre@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox