* [PATCH] tty: fix tty_ldisc_receive_buf() documentation
@ 2017-11-03 14:18 Johan Hovold
2017-11-06 13:39 ` Sebastian Reichel
0 siblings, 1 reply; 3+ messages in thread
From: Johan Hovold @ 2017-11-03 14:18 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Jiri Slaby, linux-kernel, linux-serial, Johan Hovold
The tty_ldisc_receive_buf() helper returns the number of bytes
processed so drop the bogus "not" from the kernel doc comment.
Fixes: 8d082cd300ab ("tty: Unify receive_buf() code paths")
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/tty/tty_buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c
index f8eba1c5412f..677fa99b7747 100644
--- a/drivers/tty/tty_buffer.c
+++ b/drivers/tty/tty_buffer.c
@@ -446,7 +446,7 @@ EXPORT_SYMBOL_GPL(tty_prepare_flip_string);
* Callers other than flush_to_ldisc() need to exclude the kworker
* from concurrent use of the line discipline, see paste_selection().
*
- * Returns the number of bytes not processed
+ * Returns the number of bytes processed
*/
int tty_ldisc_receive_buf(struct tty_ldisc *ld, const unsigned char *p,
char *f, int count)
--
2.15.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] tty: fix tty_ldisc_receive_buf() documentation
2017-11-03 14:18 [PATCH] tty: fix tty_ldisc_receive_buf() documentation Johan Hovold
@ 2017-11-06 13:39 ` Sebastian Reichel
2017-11-06 13:57 ` Johan Hovold
0 siblings, 1 reply; 3+ messages in thread
From: Sebastian Reichel @ 2017-11-06 13:39 UTC (permalink / raw)
To: Johan Hovold; +Cc: Greg Kroah-Hartman, Jiri Slaby, linux-kernel, linux-serial
[-- Attachment #1: Type: text/plain, Size: 1130 bytes --]
Hi,
On Fri, Nov 03, 2017 at 03:18:05PM +0100, Johan Hovold wrote:
> The tty_ldisc_receive_buf() helper returns the number of bytes
> processed so drop the bogus "not" from the kernel doc comment.
>
> Fixes: 8d082cd300ab ("tty: Unify receive_buf() code paths")
> Signed-off-by: Johan Hovold <johan@kernel.org>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
-- Sebastian
> drivers/tty/tty_buffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c
> index f8eba1c5412f..677fa99b7747 100644
> --- a/drivers/tty/tty_buffer.c
> +++ b/drivers/tty/tty_buffer.c
> @@ -446,7 +446,7 @@ EXPORT_SYMBOL_GPL(tty_prepare_flip_string);
> * Callers other than flush_to_ldisc() need to exclude the kworker
> * from concurrent use of the line discipline, see paste_selection().
> *
> - * Returns the number of bytes not processed
> + * Returns the number of bytes processed
> */
> int tty_ldisc_receive_buf(struct tty_ldisc *ld, const unsigned char *p,
> char *f, int count)
> --
> 2.15.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] tty: fix tty_ldisc_receive_buf() documentation
2017-11-06 13:39 ` Sebastian Reichel
@ 2017-11-06 13:57 ` Johan Hovold
0 siblings, 0 replies; 3+ messages in thread
From: Johan Hovold @ 2017-11-06 13:57 UTC (permalink / raw)
To: Sebastian Reichel
Cc: Johan Hovold, Greg Kroah-Hartman, Jiri Slaby, linux-kernel,
linux-serial
On Mon, Nov 06, 2017 at 02:39:44PM +0100, Sebastian Reichel wrote:
> Hi,
>
> On Fri, Nov 03, 2017 at 03:18:05PM +0100, Johan Hovold wrote:
> > The tty_ldisc_receive_buf() helper returns the number of bytes
> > processed so drop the bogus "not" from the kernel doc comment.
> >
> > Fixes: 8d082cd300ab ("tty: Unify receive_buf() code paths")
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
>
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Thanks for the review. Greg already picked this one up for next though.
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-06 13:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-03 14:18 [PATCH] tty: fix tty_ldisc_receive_buf() documentation Johan Hovold
2017-11-06 13:39 ` Sebastian Reichel
2017-11-06 13:57 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).