From: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
To: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Cc: gregkh@linuxfoundation.org, jslaby@suse.com, lukas@wunner.de,
rel+kernel@agilox.net, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, ricardo.ribalda@gmail.com,
"Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V1 1/1] serial: 8250_fintek: Fix crash with baud rate B0
Date: Wed, 8 Nov 2017 17:34:14 +0000 [thread overview]
Message-ID: <20171108173414.7b16c796@alans-desktop> (raw)
In-Reply-To: <1510110346-28893-1-git-send-email-hpeter+linux_kernel@gmail.com>
On Wed, 8 Nov 2017 11:05:46 +0800
"Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com> wrote:
> The 8250_fintek.c is support the Fintek F81866/F81216 with dynamic clock.
> But It'll generate "division by zero" exception and crash in
> fintek_8250_set_termios() with baud rate 0 on baudrate_table[i] % baud.
0 means "hang up", so this looks good providing it leaves the device in a
sane state.
Reviewed-by: Alan Cox <alan@linux.intel.com>
prev parent reply other threads:[~2017-11-08 17:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 3:05 [PATCH V1 1/1] serial: 8250_fintek: Fix crash with baud rate B0 Ji-Ze Hong (Peter Hong)
2017-11-08 17:34 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171108173414.7b16c796@alans-desktop \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hpeter+linux_kernel@gmail.com \
--cc=hpeter@gmail.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=rel+kernel@agilox.net \
--cc=ricardo.ribalda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).