From: Johan Hovold <johan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Johan Hovold <johan@kernel.org>, Rob Herring <robh@kernel.org>,
Jiri Slaby <jslaby@suse.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/8] serdev: ttyport: do not used keyed wakeup in write_wakeup
Date: Tue, 28 Nov 2017 16:16:29 +0100 [thread overview]
Message-ID: <20171128151629.GA8177@localhost> (raw)
In-Reply-To: <20171128150418.GA3341@kroah.com>
On Tue, Nov 28, 2017 at 04:04:18PM +0100, Greg Kroah-Hartman wrote:
> On Fri, Nov 03, 2017 at 03:30:59PM +0100, Johan Hovold wrote:
> > Serdev does not use the file abstraction and specifically there will
> > never be anyone polling a file descriptor for POLLOUT events.
> >
> > Just use plain wake_up_interruptible() in the write_wakeup callback and
> > document why it's there.
> >
> > Signed-off-by: Johan Hovold <johan@kernel.org>
> > ---
> > drivers/tty/serdev/serdev-ttyport.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
>
> This patch didn't apply, perhaps because I split this series across my
> "for-next" and "for-linus" branches?
That's right, this one depends on patch 4/8.
Perhaps you can take also this one through tty-linus? Or even better,
just take the whole series through tty-linus?
Johan
next prev parent reply other threads:[~2017-11-28 15:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 14:30 [PATCH 0/8] serdev: receive_buf and locking fixes Johan Hovold
2017-11-03 14:30 ` [PATCH 1/8] serdev: ttyport: add missing receive_buf sanity checks Johan Hovold
2017-11-03 14:30 ` [PATCH 2/8] serdev: fix receive_buf return value when no callback Johan Hovold
2017-11-03 14:30 ` [PATCH 3/8] serdev: document driver callbacks Johan Hovold
2017-11-03 14:30 ` [PATCH 4/8] serdev: ttyport: fix NULL-deref on hangup Johan Hovold
2017-11-03 14:30 ` [PATCH 5/8] serdev: ttyport: fix tty locking in close Johan Hovold
2017-11-03 14:30 ` [PATCH 6/8] serdev: ttyport: release tty lock sooner on open Johan Hovold
2017-11-03 14:30 ` [PATCH 7/8] serdev: ttyport: ignore carrier detect to avoid hangups Johan Hovold
2017-11-03 14:30 ` [PATCH 8/8] serdev: ttyport: do not used keyed wakeup in write_wakeup Johan Hovold
2017-11-28 15:04 ` Greg Kroah-Hartman
2017-11-28 15:16 ` Johan Hovold [this message]
2017-11-28 19:39 ` Greg Kroah-Hartman
2017-11-29 9:48 ` Johan Hovold
2017-12-15 19:26 ` Greg Kroah-Hartman
2017-12-18 11:03 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128151629.GA8177@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).