From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH 1/2] serial: stm32: add default console Date: Fri, 15 Dec 2017 20:25:17 +0100 Message-ID: <20171215192517.GA27395@kroah.com> References: <1512146211-29086-1-git-send-email-ludovic.Barre@st.com> <1512146211-29086-2-git-send-email-ludovic.Barre@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1512146211-29086-2-git-send-email-ludovic.Barre-qxv4g6HH51o@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ludovic Barre Cc: Jiri Slaby , Rob Herring , Maxime Coquelin , Alexandre Torgue , linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-serial@vger.kernel.org On Fri, Dec 01, 2017 at 05:36:50PM +0100, Ludovic Barre wrote: > From: Ludovic Barre > > This patch adds by default the console support > on stm32. Why? 'default y' should only mean "machine will not boot without this". And I think your machine will boot without the console, right? :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html