From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Jan Kundrát" <jan.kundrat@cesnet.cz>,
linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org,
"Alexander Shiyan" <shc_work@mail.ru>
Subject: Re: [PATCH] gpio: serial: max310x: Use HW type for gpio_chip's label
Date: Wed, 7 Feb 2018 06:23:51 -0800 [thread overview]
Message-ID: <20180207142351.GC29606@kroah.com> (raw)
In-Reply-To: <CACRpkdaCGmsyFGZm+2t7Vnptvi2PwFRXbq28iepDgYO0LRiUWQ@mail.gmail.com>
On Wed, Feb 07, 2018 at 02:36:33PM +0100, Linus Walleij wrote:
> On Fri, Jan 26, 2018 at 8:02 PM, Jan Kundrát <jan.kundrat@cesnet.cz> wrote:
>
> > Some debugging tools (/sys/kernel/debug/gpio, `lsgpio`) use the
> > gpio_chip's label for displaying an additional context. Right now, the
> > information duplicates stuff which is already available from the
> > parent's device. This is how e.g. `lsgpio`'s output looks like:
> >
> > GPIO chip: gpiochip2, "spi1.2", 16 GPIO lines
> >
> > Comparing the output of other GPIO expanders that I have available:
> >
> > gpiochip4: GPIOs 464-479, parent: spi/spi1.1, mcp23s17, can sleep:
> > gpiochip5: GPIOs 448-463, parent: i2c/0-0020, pca9555, can sleep:
> > gpiochip2: GPIOs 496-511, parent: spi/spi1.2, spi1.2, can sleep:
> >
> > This patch ensures that the type of the real HW device is shown instead
> > of duplicating the SPI path:
> >
> > gpiochip2: GPIOs 496-511, parent: spi/spi1.2, MAX14830, can sleep:
> >
> > Signed-off-by: Jan Kundrát <jan.kundrat@cesnet.cz>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Greg, pls apply this to your TTY tree.
Ok, let me wait until 4.16-rc1 is out first :)
greg k-h
prev parent reply other threads:[~2018-02-07 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 19:02 [PATCH] gpio: serial: max310x: Use HW type for gpio_chip's label Jan Kundrát
2018-02-07 13:36 ` Linus Walleij
2018-02-07 14:23 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180207142351.GC29606@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jan.kundrat@cesnet.cz \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox