From: Greg KH <greg@kroah.com>
To: Dave Martin <Dave.Martin@arm.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Andrew Jones <drjones@redhat.com>,
Ciro Santilli <ciro.santilli@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Russell King <linux@armlinux.org.uk>,
Wei Xu <xuwei5@hisilicon.com>,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] tty: pl011: Avoid spuriously stuck-off interrupts
Date: Sun, 29 Apr 2018 15:18:57 +0200 [thread overview]
Message-ID: <20180429131857.GC23018@kroah.com> (raw)
In-Reply-To: <1524823545-11309-1-git-send-email-Dave.Martin@arm.com>
On Fri, Apr 27, 2018 at 11:05:44AM +0100, Dave Martin wrote:
> This is an update to a previous RFC [1], to fix a problem observed by
> the qemu community that causes serial input to hang when booting a
> simulated system with data already queued in the UART FIFO [2].
>
> This patch could cause problems for people that are actually relying
> on chars queued in the PL011 RX FIFO during boot or while the UART is
> closed. There are no guarantees about such things working in general.
> In either case, there is no protection against RX FIFO overflow or
> reprogramming of the UART parameters while Linux is not actively
> receiving chars.
>
> Cheers
> ---Dave
>
> [1] [RFC PATCH v4] tty: pl011: Avoid spuriously stuck-off interrupts
> http://lists.infradead.org/pipermail/linux-arm-kernel/2018-April/574033.html
>
> [2] [Qemu-devel] [Qemu-arm] [PATCH] pl011: do not put into fifo
> before enabled the interruption
> https://lists.gnu.org/archive/html/qemu-devel/2018-01/msg06446.html
>
> Dave Martin (1):
> tty: pl011: Avoid spuriously stuck-off interrupts
>
> drivers/tty/serial/amba-pl011.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> --
> 2.1.4
There is no patch here, did something go wrong?
You do not need a "cover letter" for a single patch...
thanks,
greg k-h
next prev parent reply other threads:[~2018-04-29 13:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 10:05 [PATCH] tty: pl011: Avoid spuriously stuck-off interrupts Dave Martin
2018-04-27 10:05 ` Dave Martin
2018-05-08 11:01 ` Russell King - ARM Linux
2018-05-08 12:44 ` Dave Martin
2018-04-29 13:18 ` Greg KH [this message]
2018-04-30 12:49 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180429131857.GC23018@kroah.com \
--to=greg@kroah.com \
--cc=Dave.Martin@arm.com \
--cc=ciro.santilli@gmail.com \
--cc=drjones@redhat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=peter.maydell@linaro.org \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox