Re: [PATCH v2] tty: implement led triggers

Robin Murphy
2018-05-10T11:25:21Z

On 10/05/18 12:14, Pavel Machek wrote:
> Hi!
>
>>>>> @@ -499,6 +500,7 @@ static void flush_to_ldisc(struct work_struct *work)
>>>>> struct tty_buffer *head = buf->head;
>>>>> struct tty_buffer *next;
>>>>> int count;
>>>>> + unsigned long delay = 50 /* ms */;
>>>>
>>>> Comment after the semicolon?
>>>
>>> Given that this comment is about the 50 and not the delay member, I
>>> prefer it before the ;.
>>
>> Hmm. I personally find it hard to read and can only find about 30
>> instances of this comment style (for assignments) in the kernel. And
>> arguably the comment applies equally well to the delay variable in this
>> case too.
>
> It is not too traditional, but I believe it makes sense....
>
> (and yes, I wish we had kernel in Rust, so we could have real units
> attached to our variables...)

Well, the variable itself could always be named "delay_ms" if it's
really that important.

Robin.