From: Tony Lindgren <tony@atomide.com>
To: Johan Hovold <johan@kernel.org>
Cc: Sebastian Reichel <sre@kernel.org>,
"H. Nikolaus Schaller" <hns@goldelico.com>,
Andreas Kemnade <andreas@kemnade.info>,
Mark Rutland <mark.rutland@arm.com>,
Arnd Bergmann <arnd@arndb.de>, Pavel Machek <pavel@ucw.cz>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
linux-serial@vger.kernel.org, linux-omap@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: OMAP serial runtime PM and autosuspend (was: Re: [PATCH 4/7] dt-bindings: gnss: add u-blox binding))
Date: Wed, 9 May 2018 06:57:06 -0700 [thread overview]
Message-ID: <20180509135706.GB98604@atomide.com> (raw)
In-Reply-To: <20180509131003.GC2285@localhost>
* Johan Hovold <johan@kernel.org> [180509 13:12]:
> While this seems to fix the idling of closed ports here too, I'm not
> sure we can move use_autosuspend to startup() like this.
>
> First, this flag should be set before registering the tty so that udev
> can be used to update the attributes.
>
> Second, this prevents setting the autosuspend delay through sysfs when
> the port is closed (when autosuspend is disabled).
Yeah I noticed that too yesterday.
> It seems we really should not be using the negative autosuspend to
> configure the RPM behaviour the way these drivers do. Perhaps a new
> mechanism is needed.
Hmm well simply defaulting to "on" instead of "auto" and setting the
autosuspend_ms to 3000 by default might be doable. I think that way
we can keep use_autosuspend() in probe. Let's hope there are no
existing use cases that would break with that.
> But I'm afraid I don't have time to look at this today.
Sure np thanks,
Tony
next prev parent reply other threads:[~2018-05-09 13:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAL_JsqK=xQBx2YCd0kDP0zLn_LAZb6Mi5UfSTQf2soooVz2unQ@mail.gmail.com>
[not found] ` <20180502081637.GE2285@localhost>
[not found] ` <5242FCAD-3139-4A9C-B9FA-7BBAA0E6AE57@goldelico.com>
[not found] ` <20180503205037.7be552c1@aktux>
[not found] ` <44A0BC7C-67C7-4116-849F-90FF7CF2B1F0@goldelico.com>
[not found] ` <20180504114213.3xlzqxe74n55tk5s@earth.universe>
[not found] ` <20180507100135.GS2285@localhost>
[not found] ` <20180507154515.GP98604@atomide.com>
[not found] ` <20180507163439.GV2285@localhost>
[not found] ` <20180508155608.3bzcbepsmoskhlox@earth.universe>
2018-05-09 9:18 ` Serdev runtime PM (was: Re: [PATCH 4/7] dt-bindings: gnss: add u-blox binding) Johan Hovold
2018-05-09 9:49 ` Johan Hovold
2018-05-09 14:05 ` Tony Lindgren
2018-05-17 10:25 ` Johan Hovold
[not found] ` <20180507175032.GR98604@atomide.com>
[not found] ` <20180508065852.GW2285@localhost>
[not found] ` <20180508152228.GV98604@atomide.com>
[not found] ` <20180508154756.GW98604@atomide.com>
[not found] ` <20180508155405.GX98604@atomide.com>
[not found] ` <20180508164904.GZ98604@atomide.com>
2018-05-09 13:10 ` OMAP serial runtime PM and autosuspend (was: Re: [PATCH 4/7] dt-bindings: gnss: add u-blox binding)) Johan Hovold
2018-05-09 13:57 ` Tony Lindgren [this message]
2018-05-17 10:09 ` Johan Hovold
2018-05-17 17:10 ` Tony Lindgren
2018-05-21 13:48 ` Johan Hovold
2018-05-21 15:48 ` Tony Lindgren
2018-05-24 9:17 ` Johan Hovold
2018-05-24 13:32 ` Tony Lindgren
2018-05-25 14:02 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180509135706.GB98604@atomide.com \
--to=tony@atomide.com \
--cc=andreas@kemnade.info \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hns@goldelico.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).