From: Pavel Machek <pavel@ucw.cz>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-serial@vger.kernel.org,
Johan Hedberg <johan.hedberg@gmail.com>,
Rob Herring <robh@kernel.org>, Johan Hovold <johan@kernel.org>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 04/19] Bluetooth: hci_nokia: Add serdev_id_table
Date: Thu, 7 Jun 2018 14:51:01 +0200 [thread overview]
Message-ID: <20180607125101.GA8074@amd> (raw)
In-Reply-To: <22CF0FC7-6DC7-4DD2-9EA1-9F51B40F53E5@holtmann.org>
[-- Attachment #1: Type: text/plain, Size: 1343 bytes --]
Hi!
> >>> + { "hp4-bluetooth", },
> >>> + {},
> >>> +};
> >>> +
> >>> static struct serdev_device_driver nokia_bluetooth_serdev_driver = {
> >>> .probe = nokia_bluetooth_serdev_probe,
> >>> .remove = nokia_bluetooth_serdev_remove,
> >>> @@ -809,6 +814,7 @@ static struct serdev_device_driver nokia_bluetooth_serdev_driver = {
> >>> .pm = &nokia_bluetooth_pm_ops,
> >>> .of_match_table = of_match_ptr(nokia_bluetooth_of_match),
> >>> },
> >>> + .id_table = nokia_bluetooth_serdev_id,
> >>> };
> >>
> >> I would actually skip this hardware. First of all it is such a dedicated custom Nokia transport and hardware, and secondly it is no longer produced anyway.
> >>
> >
> > Would it make sense to cc: sre here? We want good support even for old
> > hardware, and this is n9/n950, it is still on "top ten supported
> > phones" list... Probably even top 5.
>
> but that is not what this patch series is about. We do not need new_id kinda support for the existing hardware. My point is there will be no newly designed hardware using this driver.
>
You are right, new hardware with that protocol sounds unlikely at this
point.
Sorry for the noise,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-06-07 12:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 13:09 [PATCH 00/19] Dynamically load/remove serdev devices via sysfs* Ricardo Ribalda Delgado
2018-05-29 13:09 ` [PATCH 01/19] serdev: Add id_table to serdev_device_driver Ricardo Ribalda Delgado
2018-05-29 13:09 ` [PATCH 02/19] Bluetooth: hci_bcm: Add serdev_id_table Ricardo Ribalda Delgado
2018-05-29 13:09 ` [PATCH 03/19] Bluetooth: hci_ll: " Ricardo Ribalda Delgado
2018-05-29 13:09 ` [PATCH 04/19] Bluetooth: hci_nokia: " Ricardo Ribalda Delgado
2018-06-05 13:36 ` Andy Shevchenko
2018-06-05 13:53 ` Marcel Holtmann
2018-06-07 10:27 ` Pavel Machek
2018-06-07 12:32 ` Marcel Holtmann
2018-06-07 12:51 ` Pavel Machek [this message]
2018-05-29 13:10 ` [PATCH 05/19] serdev: Introduce modalias field Ricardo Ribalda Delgado
2018-05-29 13:10 ` [PATCH 06/19] serdev: Support bus matching with " Ricardo Ribalda Delgado
2018-05-29 13:10 ` [PATCH 07/19] serdev: Allows dynamic creation of devices via sysfs Ricardo Ribalda Delgado
2018-05-29 15:38 ` Rob Herring
2018-05-29 16:30 ` Ricardo Ribalda Delgado
2018-05-29 16:32 ` Ricardo Ribalda Delgado
2018-05-29 20:35 ` Andy Shevchenko
2018-05-29 21:23 ` Ricardo Ribalda Delgado
2018-05-29 13:10 ` [PATCH 08/19] serdev: Provide modalias attribute for modalias devices Ricardo Ribalda Delgado
2018-05-29 13:10 ` [PATCH 09/19] serdev: Provide modalias uevent " Ricardo Ribalda Delgado
2018-05-29 13:10 ` [PATCH 10/19] file2alias: Support for serdev devices Ricardo Ribalda Delgado
2018-05-29 13:10 ` [PATCH 11/19] Bluetooth: hci_bcm: MODULE_DEVICE_TABLE(serdev) Ricardo Ribalda Delgado
2018-05-29 13:10 ` [PATCH 12/19] Bluetooth: hci_ll: MODULE_DEVICE_TABLE(serdev) Ricardo Ribalda Delgado
2018-05-29 13:10 ` [PATCH 13/19] Bluetooth: hci_nokia: MODULE_DEVICE_TABLE(serdev) Ricardo Ribalda Delgado
2018-05-29 13:10 ` [PATCH 14/19] mfd: rave-sp: MODULE_DEVICE_TABLE(serdev) Ricardo Ribalda Delgado
2018-05-29 13:10 ` [PATCH 15/19] net: qualcomm: MODULE_DEVICE_TABLE(serdev) Ricardo Ribalda Delgado
2018-06-01 8:59 ` Stefan Wahren
2018-05-29 13:10 ` [PATCH 16/19] serdev: ttyport: Move serport structure to its own header Ricardo Ribalda Delgado
2018-05-29 13:10 ` [PATCH 17/19] serdev: Mark controllers compatible with ttyport Ricardo Ribalda Delgado
2018-05-29 13:10 ` [PATCH 18/19] serdev: ttydev: Serdev driver that creates an standard TTY port Ricardo Ribalda Delgado
2018-06-05 13:42 ` Andy Shevchenko
2018-06-06 6:58 ` Ricardo Ribalda Delgado
2018-06-06 7:47 ` Ricardo Ribalda Delgado
2018-06-06 9:55 ` Andy Shevchenko
2018-06-06 9:58 ` Ricardo Ribalda Delgado
2018-05-29 13:10 ` [PATCH 19/19] serdev: Instantiate a ttydev serdev if acpi and of fails Ricardo Ribalda Delgado
2018-06-05 13:44 ` Andy Shevchenko
2018-06-06 7:28 ` Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180607125101.GA8074@amd \
--to=pavel@ucw.cz \
--cc=johan.hedberg@gmail.com \
--cc=johan@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=ricardo.ribalda@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).