From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steven Rostedt Subject: Re: [RFC][PATCH 0/6] Use printk_safe context for TTY and UART port locks Date: Tue, 19 Jun 2018 22:34:47 -0400 Message-ID: <20180619223447.4369748b@vmware.local.home> References: <20180615093919.559-1-sergey.senozhatsky@gmail.com> <20180618143818.50b2f2f9@alans-desktop> <20180619005308.GA405@jagdpanzerIV> <20180619083021.4avsgvcqjrpkat6s@pathway.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Linus Torvalds Cc: Petr Mladek , Sergey Senozhatsky , One Thousand Gnomes , Greg Kroah-Hartman , Jiri Slaby , Peter Zijlstra , Andrew Morton , Dmitry Vyukov , Linux Kernel Mailing List , linux-serial , SergeySenozhatsky List-Id: linux-serial@vger.kernel.org On Wed, 20 Jun 2018 11:01:49 +0900 Linus Torvalds wrote: > There is no valid reason why an UART driver should do a printk() of > any sort inside the critical region where the console is locked. > > Just remove those printk's, don't add new crazy locking. Perhaps we should do an audit of the console drivers and remove all printk, pr_* , WARN*, BUG* from them. -- Steve